ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-695

Need to remove the lookForLeader duplicated code in LENonTerminateTest

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      To do the LENonTerminateTest we need to hook into the lookForLeader code. In the last release we did this by duplicating the code. This needs to be cleaned up.

        Issue Links

          Activity

          Benjamin Reed created issue -
          Benjamin Reed made changes -
          Field Original Value New Value
          Link This issue relates to ZOOKEEPER-684 [ ZOOKEEPER-684 ]
          Hide
          Flavio Junqueira added a comment -

          Henry asked this question before in ZOOKEEPER-684 and a patch was committed before I had a chance to respond. The socket timeout I'm referring to is in LeaderElection.java:136.

          Show
          Flavio Junqueira added a comment - Henry asked this question before in ZOOKEEPER-684 and a patch was committed before I had a chance to respond. The socket timeout I'm referring to is in LeaderElection.java:136.
          Hide
          Henry Robinson added a comment -

          Flavio -

          I believe that timeouts can be an issue, and that 200ms is maybe a bit aggressive. I'm not sure that was the problem in ZOOKEEPER-684; I really think the issue there was the race on doing a round of voting in lockstep.

          It might make sense to increase the timeout in the test code - let's do that as part of this JIRA for 3.4.0.

          Henry

          Show
          Henry Robinson added a comment - Flavio - I believe that timeouts can be an issue, and that 200ms is maybe a bit aggressive. I'm not sure that was the problem in ZOOKEEPER-684 ; I really think the issue there was the race on doing a round of voting in lockstep. It might make sense to increase the timeout in the test code - let's do that as part of this JIRA for 3.4.0. Henry
          Hide
          Flavio Junqueira added a comment -

          I was trying to draft a response and then I realized that I don't think we need a timeout to get the race I was thinking about, so I think you're right, Henry. In fact if there had been a timeout in that log, there would be a log message saying that the response was short, and I can't find such a message.

          Show
          Flavio Junqueira added a comment - I was trying to draft a response and then I realized that I don't think we need a timeout to get the race I was thinking about, so I think you're right, Henry. In fact if there had been a timeout in that log, there would be a log message saying that the response was short, and I can't find such a message.

            People

            • Assignee:
              Unassigned
              Reporter:
              Benjamin Reed
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development