Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-668

Close method in LedgerInputStream doesn't do anything

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None

      Description

      I think we should remove the close call in LedgerInputStream.

      1. ZOOKEEPER-668.patch
        0.7 kB
        Flavio Junqueira
      2. ZOOKEEPER-668.patch
        0.6 kB
        Flavio Junqueira

        Activity

        Hide
        fpj Flavio Junqueira added a comment -

        Removed the empty method.

        Show
        fpj Flavio Junqueira added a comment - Removed the empty method.
        Hide
        breed Benjamin Reed added a comment -

        perhaps we should add javadoc stating that the ledger handle will not be closed. For example BufferedInputStream.close() closes the underlying stream, so there is some ambiguity if we do not close it.

        Show
        breed Benjamin Reed added a comment - perhaps we should add javadoc stating that the ledger handle will not be closed. For example BufferedInputStream.close() closes the underlying stream, so there is some ambiguity if we do not close it.
        Hide
        fpj Flavio Junqueira added a comment -

        Suggestion taken, uploading new patch.

        Show
        fpj Flavio Junqueira added a comment - Suggestion taken, uploading new patch.
        Hide
        mahadev Mahadev konar added a comment -

        +1 for the patch!
        I just committed this. thanks flavio!

        Show
        mahadev Mahadev konar added a comment - +1 for the patch! I just committed this. thanks flavio!
        Hide
        hudson Hudson added a comment -

        Integrated in ZooKeeper-trunk #701 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/)

        Show
        hudson Hudson added a comment - Integrated in ZooKeeper-trunk #701 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/ )

          People

          • Assignee:
            fpj Flavio Junqueira
            Reporter:
            fpj Flavio Junqueira
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development