ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-668

Close method in LedgerInputStream doesn't do anything

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None

      Description

      I think we should remove the close call in LedgerInputStream.

      1. ZOOKEEPER-668.patch
        0.6 kB
        Flavio Junqueira
      2. ZOOKEEPER-668.patch
        0.7 kB
        Flavio Junqueira

        Activity

        Flavio Junqueira created issue -
        Hide
        Flavio Junqueira added a comment -

        Removed the empty method.

        Show
        Flavio Junqueira added a comment - Removed the empty method.
        Flavio Junqueira made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-668.patch [ 12435694 ]
        Flavio Junqueira made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Flavio Paiva Junqueira [ fpj ]
        Hide
        Benjamin Reed added a comment -

        perhaps we should add javadoc stating that the ledger handle will not be closed. For example BufferedInputStream.close() closes the underlying stream, so there is some ambiguity if we do not close it.

        Show
        Benjamin Reed added a comment - perhaps we should add javadoc stating that the ledger handle will not be closed. For example BufferedInputStream.close() closes the underlying stream, so there is some ambiguity if we do not close it.
        Hide
        Flavio Junqueira added a comment -

        Suggestion taken, uploading new patch.

        Show
        Flavio Junqueira added a comment - Suggestion taken, uploading new patch.
        Flavio Junqueira made changes -
        Attachment ZOOKEEPER-668.patch [ 12435987 ]
        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Flavio Junqueira made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mahadev konar added a comment -

        +1 for the patch!
        I just committed this. thanks flavio!

        Show
        Mahadev konar added a comment - +1 for the patch! I just committed this. thanks flavio!
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #701 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #701 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/ )
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        4d 4h 26m 1 Flavio Junqueira 16/Feb/10 16:54
        Open Open Patch Available Patch Available
        16m 44s 2 Flavio Junqueira 16/Feb/10 16:54
        Patch Available Patch Available Resolved Resolved
        2d 9h 48m 1 Mahadev konar 19/Feb/10 02:43
        Resolved Resolved Closed Closed
        35d 14h 42m 1 Patrick Hunt 26/Mar/10 17:25

          People

          • Assignee:
            Flavio Junqueira
            Reporter:
            Flavio Junqueira
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development