ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-657

Cut down the running time of ZKDatabase corruption.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.7, 3.5.0
    • Component/s: tests
    • Labels:
      None

      Description

      THe zkdatabasecorruption test takes around 180 seconds right now. It just bring down a quorum cluster up and down and corrupts some snapshots. We need to investigate why it takes that long and make it shorter so that our test run times are smaller.

      1. ZOOKEEPER-657.patch
        2 kB
        Michi Mutsuzaki

        Activity

        Hide
        Hudson added a comment -

        FAILURE: Integrated in ZooKeeper-trunk #2311 (See https://builds.apache.org/job/ZooKeeper-trunk/2311/)
        ZOOKEEPER-657. Cut down the running time of ZKDatabase corruption (Michi Mutsuzaki via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594755)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZkDatabaseCorruptionTest.java
        Show
        Hudson added a comment - FAILURE: Integrated in ZooKeeper-trunk #2311 (See https://builds.apache.org/job/ZooKeeper-trunk/2311/ ) ZOOKEEPER-657 . Cut down the running time of ZKDatabase corruption (Michi Mutsuzaki via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594755 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZkDatabaseCorruptionTest.java
        Hide
        Rakesh R added a comment -
        Show
        Rakesh R added a comment - Committed trunk revision: http://svn.apache.org/viewvc?view=revision&revision=1594755 Committed branch-3.4 revision: http://svn.apache.org/viewvc?view=revision&revision=1594756
        Hide
        Rakesh R added a comment -

        Thanks Michi Mutsuzaki, the patch improves the test exec time in my env. I've executed the testcase with the patch, it reduces from 55 secs to 12 secs(ran 10times and this value is average).

        +1 lgtm

        Show
        Rakesh R added a comment - Thanks Michi Mutsuzaki , the patch improves the test exec time in my env. I've executed the testcase with the patch, it reduces from 55 secs to 12 secs(ran 10times and this value is average). +1 lgtm
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12644200/ZOOKEEPER-657.patch
        against trunk revision 1593624.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2087//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2087//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2087//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644200/ZOOKEEPER-657.patch against trunk revision 1593624. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2087//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2087//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2087//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        Use asynchronous create. This patch reduces the test runtime from 130 seconds to 10 seconds on my box.

        Show
        Michi Mutsuzaki added a comment - Use asynchronous create. This patch reduces the test runtime from 130 seconds to 10 seconds on my box.
        Hide
        Mahadev konar added a comment -

        moving it to 3.4 since its not a blocker.

        Show
        Mahadev konar added a comment - moving it to 3.4 since its not a blocker.

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development