ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-656

SledgeHammer test - thread.run() deprecated

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Thread.run() used instead of Thread.start() .

        Activity

        Karthik K created issue -
        Karthik K made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-656.patch [ 12431229 ]
        Karthik K made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Karthik K added a comment -

        courtesy: findbugs report

        Show
        Karthik K added a comment - courtesy: findbugs report
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12431229/ZOOKEEPER-656.patch
        against trunk revision 902320.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/54/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/54/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431229/ZOOKEEPER-656.patch against trunk revision 902320. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/54/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/54/console This message is automatically generated.
        Mahadev konar made changes -
        Assignee Kay Kay [ kaykay.unique ]
        Fix Version/s 3.3.0 [ 12313976 ]
        Hide
        Mahadev konar added a comment -

        +1... good catch.....

        Show
        Mahadev konar added a comment - +1... good catch.....
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks Kay Kay.

        Show
        Mahadev konar added a comment - I just committed this. thanks Kay Kay.
        Mahadev konar made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #678 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/678/)
        . SledgeHammer test - thread.run() deprecated (kay kay via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #678 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/678/ ) . SledgeHammer test - thread.run() deprecated (kay kay via mahadev)
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        55s 1 Karthik K 24/Jan/10 01:28
        Patch Available Patch Available Resolved Resolved
        1d 2h 7m 1 Mahadev konar 25/Jan/10 03:35
        Resolved Resolved Closed Closed
        60d 13h 49m 1 Patrick Hunt 26/Mar/10 17:25

          People

          • Assignee:
            Karthik K
            Reporter:
            Karthik K
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development