ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-655

StringBuffer -> StringBuilder - conversion of references as necessary

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 3.3.0
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Some of the 'StringBuffer' references that do not escape the scope of the method can be better typed as StringBuilder as concurrency is not needed in that case.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Hadoop QA added a comment -

            +1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12431226/ZOOKEEPER-655.patch
            against trunk revision 902320.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 9 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431226/ZOOKEEPER-655.patch against trunk revision 902320. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/console This message is automatically generated.
            Hide
            Permalink
            Henry Robinson added a comment -

            +1 looks good to me - all tests pass when patch is applied to trunk.

            Show
            Henry Robinson added a comment - +1 looks good to me - all tests pass when patch is applied to trunk.
            Hide
            Permalink
            Mahadev konar added a comment -

            good point....
            +1 for the patch....

            Show
            Mahadev konar added a comment - good point.... +1 for the patch....
            Hide
            Permalink
            Henry Robinson added a comment -

            I just committed this - thanks Kay!

            Show
            Henry Robinson added a comment - I just committed this - thanks Kay!
            Hide
            Permalink
            Hudson added a comment -

            Integrated in ZooKeeper-trunk #678 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/678/)
            . StringBuffer -> StringBuilder - conversion of references as necessary (Kay Kay via henry)

            Show
            Hudson added a comment - Integrated in ZooKeeper-trunk #678 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/678/ ) . StringBuffer -> StringBuilder - conversion of references as necessary (Kay Kay via henry)

              People

              • Assignee:
                Karthik K
                Reporter:
                Karthik K
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development