ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-651

Log exception trace in QuorumCnxManager.SendWorker

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0, 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There is an error log message that only outputs a constant string. It would be good to have the trace as well.

      1. ZOOKEEPER-651.patch
        0.7 kB
        Flavio Junqueira

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12430735/ZOOKEEPER-651.patch
        against trunk revision 899383.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/108/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/108/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430735/ZOOKEEPER-651.patch against trunk revision 899383. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/108/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/108/console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        There is no need for tests for this patch.

        Show
        Flavio Junqueira added a comment - There is no need for tests for this patch.
        Hide
        Henry Robinson added a comment -

        +1 looks good to me.

        Show
        Henry Robinson added a comment - +1 looks good to me.
        Hide
        Henry Robinson added a comment -

        I just commited this. Thanks Flavio!

        Show
        Henry Robinson added a comment - I just commited this. Thanks Flavio!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #674 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/674/)
        :Log exception trace in QuorumCnxManager.SendWorker (flavio via henry)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #674 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/674/ ) :Log exception trace in QuorumCnxManager.SendWorker (flavio via henry)

          People

          • Assignee:
            Flavio Junqueira
            Reporter:
            Flavio Junqueira
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development