ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-626

ensure the c/java cli's print xid/sessionid/etc... in hex

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: c client, java client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Java/c clients should output xid/sessionids (incl ephemeralowner) in hex format

      private static void printStat(Stat stat)

      { System.err.println("cZxid = " + stat.getCzxid()); System.err.println("ctime = " + new Date(stat.getCtime()).toString()); System.err.println("mZxid = " + stat.getMzxid()); System.err.println("mtime = " + new Date(stat.getMtime()).toString()); System.err.println("pZxid = " + stat.getPzxid()); System.err.println("cversion = " + stat.getCversion()); System.err.println("dataVersion = " + stat.getVersion()); System.err.println("aclVersion = " + stat.getAversion()); System.err.println("ephemeralOwner = " + stat.getEphemeralOwner()); System.err.println("dataLength = " + stat.getDataLength()); System.err.println("numChildren = " + stat.getNumChildren()); }

        Activity

        Hide
        Patrick Hunt added a comment -

        fixes java cli output, I also verified c cli which is already doing this correctly (no change necessary)

        Show
        Patrick Hunt added a comment - fixes java cli output, I also verified c cli which is already doing this correctly (no change necessary)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12430923/ZOOKEEPER-626.patch
        against trunk revision 900939.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/42/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/42/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/42/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430923/ZOOKEEPER-626.patch against trunk revision 900939. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/42/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/42/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/42/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 I just committed this. thanks pat.

        Show
        Mahadev konar added a comment - +1 I just committed this. thanks pat.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #676 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/676/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #676 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/676/ )

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development