ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-614

Improper synchronisation in getClientCnxnCount

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1, 3.2.2
    • Fix Version/s: 3.3.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      getClientCnxnCount reads from Factory.ipMap without synchronizing.

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #625 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #625 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/ )
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks henry!

        Show
        Mahadev konar added a comment - I just committed this. thanks henry!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12427252/ZOOKEEPER-614.patch
        against trunk revision 889797.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427252/ZOOKEEPER-614.patch against trunk revision 889797. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        trying hudson.

        Show
        Mahadev konar added a comment - trying hudson.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good. ill wait for hudson to run it and will commit it...

        Show
        Mahadev konar added a comment - +1 the patch looks good. ill wait for hudson to run it and will commit it...
        Hide
        Patrick Hunt added a comment -

        After review with Henry - pushing to 3.3.0.

        Show
        Patrick Hunt added a comment - After review with Henry - pushing to 3.3.0.
        Hide
        Henry Robinson added a comment -

        Issue was a simple fix - to test, made MaxCnxnsTest use concurrent connections rather than serial code. This won't test for any bugs explicitly (this is a defensive fix, anyhow), but it gives them a chance to show themselves

        Show
        Henry Robinson added a comment - Issue was a simple fix - to test, made MaxCnxnsTest use concurrent connections rather than serial code. This won't test for any bugs explicitly (this is a defensive fix, anyhow), but it gives them a chance to show themselves

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development