Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1, 3.2.1
    • Fix Version/s: 3.1.2, 3.2.2, 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The hudson build failure failed again on

      http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/582/

      1. ZOOKEEPER-611-3.1.patch
        1 kB
        Mahadev konar
      2. ZOOKEEPER-611-3.2.patch
        1 kB
        Mahadev konar
      3. ZOOKEEPER-611.patch
        2 kB
        Mahadev konar
      4. ZOOKEEPER-611.patch
        0.9 kB
        Mahadev konar
      5. ZOOKEEPER-611.patch
        0.8 kB
        Mahadev konar

        Activity

        Hide
        Mahadev konar added a comment -
        
        

        2009-12-06 21:59:23,352 - ERROR [QuorumPeer with myid:1 and clientPort:3181:QuorumPeerTestBase$MainThread@92] - unexpected exception in run
        java.lang.NullPointerException
        at sun.nio.ch.Util.atBugLevel(Util.java:326)
        at sun.nio.ch.SelectorImpl.<init>(SelectorImpl.java:40)
        at sun.nio.ch.EPollSelectorImpl.<init>(EPollSelectorImpl.java:47)
        at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18)
        at java.nio.channels.Selector.open(Selector.java:209)
        at org.apache.zookeeper.server.NIOServerCnxn$Factory.<init>(NIOServerCnxn.java:98)
        at org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:120)
        at org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:102)
        at org.apache.zookeeper.server.quorum.QuorumPeerTestBase$MainThread.run(QuorumPeerTestBase.java:89)

        This was the exception in the logs which caused the quorumpeer run method to die. I thought we had fixed the issue in ZOOKEEPER-597 but looks like it isnt fully fixed.

        Show
        Mahadev konar added a comment - 2009-12-06 21:59:23,352 - ERROR [QuorumPeer with myid:1 and clientPort:3181:QuorumPeerTestBase$MainThread@92] - unexpected exception in run java.lang.NullPointerException at sun.nio.ch.Util.atBugLevel(Util.java:326) at sun.nio.ch.SelectorImpl.<init>(SelectorImpl.java:40) at sun.nio.ch.EPollSelectorImpl.<init>(EPollSelectorImpl.java:47) at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18) at java.nio.channels.Selector.open(Selector.java:209) at org.apache.zookeeper.server.NIOServerCnxn$Factory.<init>(NIOServerCnxn.java:98) at org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:120) at org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:102) at org.apache.zookeeper.server.quorum.QuorumPeerTestBase$MainThread.run(QuorumPeerTestBase.java:89) This was the exception in the logs which caused the quorumpeer run method to die. I thought we had fixed the issue in ZOOKEEPER-597 but looks like it isnt fully fixed.
        Hide
        Patrick Hunt added a comment -
        Show
        Patrick Hunt added a comment - looks like similar problem here: http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/586/
        Hide
        Flavio Junqueira added a comment -

        For 588, same problem, but now triggered from the CnxManager test:

        java.lang.NullPointerException
        	at sun.nio.ch.Util.atBugLevel(Util.java:326)
        	at sun.nio.ch.SelectorImpl.<init>(SelectorImpl.java:40)
        	at sun.nio.ch.EPollSelectorImpl.<init>(EPollSelectorImpl.java:47)
        	at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18)
        	at java.nio.channels.Selector.open(Selector.java:209)
        	at org.apache.zookeeper.server.NIOServerCnxn$Factory.<init>(NIOServerCnxn.java:98)
        	at org.apache.zookeeper.server.NIOServerCnxn$Factory.<init>(NIOServerCnxn.java:123)
        	at org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:414)
        	at org.apache.zookeeper.test.CnxManagerTest.testCnxManager(CnxManagerTest.java:152)
        
        Show
        Flavio Junqueira added a comment - For 588, same problem, but now triggered from the CnxManager test: java.lang.NullPointerException at sun.nio.ch.Util.atBugLevel(Util.java:326) at sun.nio.ch.SelectorImpl.<init>(SelectorImpl.java:40) at sun.nio.ch.EPollSelectorImpl.<init>(EPollSelectorImpl.java:47) at sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18) at java.nio.channels.Selector.open(Selector.java:209) at org.apache.zookeeper.server.NIOServerCnxn$Factory.<init>(NIOServerCnxn.java:98) at org.apache.zookeeper.server.NIOServerCnxn$Factory.<init>(NIOServerCnxn.java:123) at org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:414) at org.apache.zookeeper.test.CnxManagerTest.testCnxManager(CnxManagerTest.java:152)
        Hide
        Mahadev konar added a comment -

        this patch fixes this nullpointer exception by setting the system property ""sun.nio.ch.bugLevel" to empty string. It also removes the selector.open().close() that we put in ZOOKEEPER-597 as a solution to the same problem.

        Show
        Mahadev konar added a comment - this patch fixes this nullpointer exception by setting the system property ""sun.nio.ch.bugLevel" to empty string. It also removes the selector.open().close() that we put in ZOOKEEPER-597 as a solution to the same problem.
        Hide
        Benjamin Reed added a comment -

        we should probably check if that property is set before overwriting it we should probably also have a comment pointing out that this is a work around for the sun bug (and point to the bug)

        Show
        Benjamin Reed added a comment - we should probably check if that property is set before overwriting it we should probably also have a comment pointing out that this is a work around for the sun bug (and point to the bug)
        Hide
        Benjamin Reed added a comment -

        scratch the point to the bug part. it is already there.

        Show
        Benjamin Reed added a comment - scratch the point to the bug part. it is already there.
        Hide
        Mahadev konar added a comment -

        attached patch with ben's comments.

        Show
        Mahadev konar added a comment - attached patch with ben's comments.
        Hide
        Benjamin Reed added a comment -

        +1

        Show
        Benjamin Reed added a comment - +1
        Hide
        Mahadev konar added a comment -

        I just committed this. good catch ben!

        Show
        Mahadev konar added a comment - I just committed this. good catch ben!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #590 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/590/)
        . hudson build failiure (mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #590 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/590/ ) . hudson build failiure (mahadev)
        Hide
        Mahadev konar added a comment -

        doesnt looks like its fixed,

        http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/593/

        looks like the static block should be in Factory rather than Servercnxn. Thanks pat for pointing out.

        Show
        Mahadev konar added a comment - doesnt looks like its fixed, http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/593/ looks like the static block should be in Factory rather than Servercnxn. Thanks pat for pointing out.
        Hide
        Mahadev konar added a comment -

        resubmitting a patch for static block in Factory.

        Show
        Mahadev konar added a comment - resubmitting a patch for static block in Factory.
        Hide
        Mahadev konar added a comment -

        attached a wrong file.

        Show
        Mahadev konar added a comment - attached a wrong file.
        Hide
        Patrick Hunt added a comment -

        +1, looks good.

        Show
        Patrick Hunt added a comment - +1, looks good.
        Hide
        Mahadev konar added a comment -

        I just committed this.

        Show
        Mahadev konar added a comment - I just committed this.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #596 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/596/)
        . hudson build failure (take 2) (mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #596 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/596/ ) . hudson build failure (take 2) (mahadev)
        Hide
        Mahadev konar added a comment -

        ill upload a patch for 3.1 and 3.2 branch as soon as ZOOKEEPER-597 gets committed to those branches.

        Show
        Mahadev konar added a comment - ill upload a patch for 3.1 and 3.2 branch as soon as ZOOKEEPER-597 gets committed to those branches.
        Hide
        Mahadev konar added a comment -

        reopeneing for 3.1 and 3.2 branches.

        Show
        Mahadev konar added a comment - reopeneing for 3.1 and 3.2 branches.
        Hide
        Mahadev konar added a comment -

        patch for 3.2 branch. adds the uncaught handler and fixes works around the jvm bug.

        Show
        Mahadev konar added a comment - patch for 3.2 branch. adds the uncaught handler and fixes works around the jvm bug.
        Hide
        Mahadev konar added a comment -

        patch for 3.1. add the thread handler and works arnd the jvm bug.

        Show
        Mahadev konar added a comment - patch for 3.1. add the thread handler and works arnd the jvm bug.
        Hide
        Benjamin Reed added a comment -

        +1 looks good

        Show
        Benjamin Reed added a comment - +1 looks good
        Hide
        Mahadev konar added a comment -

        I just committed this to 3.1 and 3.2 branches.

        Show
        Mahadev konar added a comment - I just committed this to 3.1 and 3.2 branches.

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development