ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-602

log all exceptions not caught by ZK threads

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.5.0
    • Component/s: java client, server
    • Labels:
      None

      Description

      the java code should add a ThreadGroup exception handler that logs at ERROR level any uncaught exceptions thrown by Thread run methods.

      1. ZOOKEEPER-602.patch
        29 kB
        Rakesh R
      2. ZOOKEEPER-602.patch
        29 kB
        Rakesh R
      3. ZOOKEEPER-602.patch
        29 kB
        Rakesh R
      4. ZOOKEEPER-602.patch
        29 kB
        Rakesh R
      5. ZOOKEEPER-602.patch
        28 kB
        Rakesh R
      6. ZOOKEEPER-602.patch
        30 kB
        Laxman
      7. ZOOKEEPER-602.patch
        29 kB
        Laxman

        Issue Links

          Activity

          Hide
          Benjamin Reed added a comment -

          i think the best strategy to address this would be to create a ZooKeeperThread that all the code must use with the following properties:

          1) it has a single constructor ZooKeeperThread(String threadName, long sid, boolean isUnhandledExceptionFatal), where threadName is a descriptive string, sid is the server id or -1 if not relevant,

          2) exceptions will be logged as errors unless isUnhandledExceptionFatal is true, then an unhandle exception on that thread will be logged as fatal and cause a shutdown.

          Show
          Benjamin Reed added a comment - i think the best strategy to address this would be to create a ZooKeeperThread that all the code must use with the following properties: 1) it has a single constructor ZooKeeperThread(String threadName, long sid, boolean isUnhandledExceptionFatal), where threadName is a descriptive string, sid is the server id or -1 if not relevant, 2) exceptions will be logged as errors unless isUnhandledExceptionFatal is true, then an unhandle exception on that thread will be logged as fatal and cause a shutdown.
          Hide
          Mahadev konar added a comment -

          moving this issue to 3.4

          Show
          Mahadev konar added a comment - moving this issue to 3.4
          Hide
          Mahadev konar added a comment -

          not a blocker. Moving it out of 3.4 release.

          Show
          Mahadev konar added a comment - not a blocker. Moving it out of 3.4 release.
          Hide
          Laxman added a comment -

          Attached the patch for review

          Show
          Laxman added a comment - Attached the patch for review
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12495070/ZOOKEEPER-602.patch
          against trunk revision 1172406.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/560//testReport/
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/560//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495070/ZOOKEEPER-602.patch against trunk revision 1172406. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/560//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/560//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Looks like a case sensitivity issue:

          [exec] [javac] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/main/org/apache/zookeeper/server/ZookeeperThread.java:6: class ZooKeeperThread is public, should be declared in a file named ZooKeeperThread.java

          Show
          Patrick Hunt added a comment - Looks like a case sensitivity issue: [exec] [javac] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/main/org/apache/zookeeper/server/ZookeeperThread.java:6: class ZooKeeperThread is public, should be declared in a file named ZooKeeperThread.java
          Hide
          Laxman added a comment -

          Following are the threads severity I've considered.
          If a thread is a Critical thread, then any unexpected exceptions (i.e., exceptions not handled by the thread) are considered as Fatal and JVM will shutdown.

          ZooKeeper Threads Critical Thread
          PrepRequestProcessor TRUE
          SessionTrackerImpl TRUE
          SyncRequestProcessor TRUE
          CommitProcessor TRUE
          FollowerRequestProcessor TRUE
          ObserverRequestProcessor TRUE
          ReadOnlyRequestProcessor TRUE
          RecvWorker FALSE
          EventThread FALSE
          SendThread FALSE
          CommandThread FALSE
          WorkerReceiver FALSE
          WorkerSender FALSE
          LearnerCnxAcceptor FALSE
          Listener FALSE
          LearnerHandler FALSE
          QuorumPeer FALSE
          SendWorker FALSE
          ResponderThread FALSE
          Show
          Laxman added a comment - Following are the threads severity I've considered. If a thread is a Critical thread, then any unexpected exceptions (i.e., exceptions not handled by the thread) are considered as Fatal and JVM will shutdown. ZooKeeper Threads Critical Thread PrepRequestProcessor TRUE SessionTrackerImpl TRUE SyncRequestProcessor TRUE CommitProcessor TRUE FollowerRequestProcessor TRUE ObserverRequestProcessor TRUE ReadOnlyRequestProcessor TRUE RecvWorker FALSE EventThread FALSE SendThread FALSE CommandThread FALSE WorkerReceiver FALSE WorkerSender FALSE LearnerCnxAcceptor FALSE Listener FALSE LearnerHandler FALSE QuorumPeer FALSE SendWorker FALSE ResponderThread FALSE
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12496990/ZOOKEEPER-602.patch
          against trunk revision 1177432.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/599//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/599//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/599//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496990/ZOOKEEPER-602.patch against trunk revision 1177432. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/599//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/599//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/599//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12496990/ZOOKEEPER-602.patch
          against trunk revision 1188033.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/642//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496990/ZOOKEEPER-602.patch against trunk revision 1188033. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/642//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          I'd like to see this go in - seems the patch needs to be updated for conflicts, also some findbugs issues.

          Show
          Patrick Hunt added a comment - I'd like to see this go in - seems the patch needs to be updated for conflicts, also some findbugs issues.
          Hide
          Laxman added a comment -

          Thanks for the interest Pat.
          I will refresh the patch on latest trunk.

          also some findbugs issues

          One System.exit is introduced which is part of the fix.

          Can you please take a look at my previous comments about criticality of threads.
          https://issues.apache.org/jira/browse/ZOOKEEPER-602?focusedCommentId=13117887&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13117887

          Show
          Laxman added a comment - Thanks for the interest Pat. I will refresh the patch on latest trunk. also some findbugs issues One System.exit is introduced which is part of the fix. Can you please take a look at my previous comments about criticality of threads. https://issues.apache.org/jira/browse/ZOOKEEPER-602?focusedCommentId=13117887&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13117887
          Hide
          Rakesh R added a comment -

          Attached patch, which contains ZooKeeperThread and ZooKeeperCriticalThread to handle the uncaught exceptions. I've added fix version 3.4.6 also, because I have seen many discussions related to missing threads and this will be helpful to know about the reason of thread exit. Please feel free to change the versions if anyone has different thoughts

          This will cause findbug warning as it has System.exit() call in ZooKeeperCriticalThread and done exclusion of this.

          Show
          Rakesh R added a comment - Attached patch, which contains ZooKeeperThread and ZooKeeperCriticalThread to handle the uncaught exceptions. I've added fix version 3.4.6 also, because I have seen many discussions related to missing threads and this will be helpful to know about the reason of thread exit. Please feel free to change the versions if anyone has different thoughts This will cause findbug warning as it has System.exit() call in ZooKeeperCriticalThread and done exclusion of this.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615124/ZOOKEEPER-602.patch
          against trunk revision 1543281.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615124/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615139/ZOOKEEPER-602.patch
          against trunk revision 1543281.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615139/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615143/ZOOKEEPER-602.patch
          against trunk revision 1543281.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615143/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615151/ZOOKEEPER-602.patch
          against trunk revision 1543281.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615151/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//console This message is automatically generated.
          Hide
          Raul Gutierrez Segales added a comment -

          Two nits:

          +    class LearnerCnxAcceptor extends ZooKeeperThread{
          

          space missing (ZooKeeperThread {)

          Typo:

          +            // When there is no worker thread pool, do the work directly 
          +            // and waiting for its completion
          

          "and wait for its completion"

          Show
          Raul Gutierrez Segales added a comment - Two nits: + class LearnerCnxAcceptor extends ZooKeeperThread{ space missing (ZooKeeperThread {) Typo: + // When there is no worker thread pool, do the work directly + // and waiting for its completion "and wait for its completion"
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615275/ZOOKEEPER-602.patch
          against trunk revision 1543281.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615275/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//console This message is automatically generated.
          Hide
          Rakesh R added a comment -

          Thank you Raul Gutierrez Segales for the review. Attached latest patch addressing the comments.

          Show
          Rakesh R added a comment - Thank you Raul Gutierrez Segales for the review. Attached latest patch addressing the comments.
          Hide
          Rakesh R added a comment -

          Hi folks,
          Could someone help me to review the patch/changes and would appreciate the efforts. Thanks in advance

          Show
          Rakesh R added a comment - Hi folks, Could someone help me to review the patch/changes and would appreciate the efforts. Thanks in advance
          Hide
          Flavio Junqueira added a comment -

          Could you put this on the review board, please?

          Show
          Flavio Junqueira added a comment - Could you put this on the review board, please?
          Hide
          Rakesh R added a comment -

          Thank you Flavio Junqueira for the interest. Please find the review at https://reviews.apache.org/r/16202/

          Show
          Rakesh R added a comment - Thank you Flavio Junqueira for the interest. Please find the review at https://reviews.apache.org/r/16202/
          Hide
          Patrick Hunt added a comment -

          I took a pass and this seems reasonable. I'm not sure I like the idea of modifying all the threads to extend our own thread type, but it gets the job done. I don't think we should commit this for 3.4, trunk would be better IMO.

          Show
          Patrick Hunt added a comment - I took a pass and this seems reasonable. I'm not sure I like the idea of modifying all the threads to extend our own thread type, but it gets the job done. I don't think we should commit this for 3.4, trunk would be better IMO.
          Hide
          Rakesh R added a comment -

          Thank you Patrick Hunt for looking at this. I agree its not a blocker for 3.4.6.
          I've added fix version 3.4.6, because I have seen many cases related to missing threads. I thought this fix doesn't affect compatibility and will be helpful to know about the reason of thread exit.

          Show
          Rakesh R added a comment - Thank you Patrick Hunt for looking at this. I agree its not a blocker for 3.4.6. I've added fix version 3.4.6, because I have seen many cases related to missing threads. I thought this fix doesn't affect compatibility and will be helpful to know about the reason of thread exit.
          Hide
          Patrick Hunt added a comment -

          No worries Rakesh R, I could see it going into 3.4, but since it's touching so many files, and it's difficult to verify, I thought it best to target trunk instead.

          Do you think the benefit outweighs the risk?

          Show
          Patrick Hunt added a comment - No worries Rakesh R , I could see it going into 3.4, but since it's touching so many files, and it's difficult to verify, I thought it best to target trunk instead. Do you think the benefit outweighs the risk?
          Hide
          Rakesh R added a comment -

          yeah..ok, I got your point. I also feel its best to target trunk

          Show
          Rakesh R added a comment - yeah..ok, I got your point. I also feel its best to target trunk
          Hide
          Michi Mutsuzaki added a comment -

          It seems like this patch is good to go in to trunk. I'm checking this in tomorrow unless somebody complains.

          Show
          Michi Mutsuzaki added a comment - It seems like this patch is good to go in to trunk. I'm checking this in tomorrow unless somebody complains.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615275/ZOOKEEPER-602.patch
          against trunk revision 1577756.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1976//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1976//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1976//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615275/ZOOKEEPER-602.patch against trunk revision 1577756. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1976//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1976//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1976//console This message is automatically generated.
          Hide
          Michi Mutsuzaki added a comment -
          Show
          Michi Mutsuzaki added a comment - trunk: http://svn.apache.org/viewvc?view=revision&revision=1580436 Thanks Rakesh!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in ZooKeeper-trunk #2263 (See https://builds.apache.org/job/ZooKeeper-trunk/2263/)
          ZOOKEEPER-602. log all exceptions not caught by ZK threads (Rakesh R via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1580436)

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WorkerService.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
          • /zookeeper/trunk/src/java/test/config/findbugsExcludeFile.xml
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java
          Show
          Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2263 (See https://builds.apache.org/job/ZooKeeper-trunk/2263/ ) ZOOKEEPER-602 . log all exceptions not caught by ZK threads (Rakesh R via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1580436 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WorkerService.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java /zookeeper/trunk/src/java/test/config/findbugsExcludeFile.xml /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java

            People

            • Assignee:
              Rakesh R
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development