ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-601

allow configuration of session timeout min/max bounds

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ZK servers currently enforce a min/max boundary on client session timeout relative to the ticktime setting, detailed here:
      http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions

      In general there are good reasons for this however in some cases, in particular with HBase region servers, we have seen a need to allow this bound to be set differently (higher). The Sun jvm can GC pause for very long times (in some cases we've seen 4 minutes even with the "realtime" gc.

      It would be good to allow this bound to be set via configuration parameters.

      Note: 4letterword and JMX integration would be needed.

      1. ZOOKEEPER-601.patch
        45 kB
        Patrick Hunt
      2. ZOOKEEPER-601.patch
        46 kB
        Patrick Hunt

        Issue Links

          Activity

          Patrick Hunt created issue -
          Patrick Hunt made changes -
          Field Original Value New Value
          Assignee Patrick Hunt [ phunt ]
          Hide
          Patrick Hunt added a comment -

          ZOOKEEPER-595 and ZOOKEEPER-617 are also addressed in this patch

          1) the min/max session timeout can now be configured for a server (conf file/ jmx support enabled)
          2) the "conf" 4letter word has been added (595)
          3) cleanup some forrest doc (617)

          During review please note:

          1) new file added, be sure to svn add it
          2) LeaderZKServer was missing a getServerID override, added it
          3) test the "conf" 4 letter word
          4) test jmx, verify you can see the params
          5) tests added for everything
          6) be sure to regenerate the forrest docs and commit

          Show
          Patrick Hunt added a comment - ZOOKEEPER-595 and ZOOKEEPER-617 are also addressed in this patch 1) the min/max session timeout can now be configured for a server (conf file/ jmx support enabled) 2) the "conf" 4letter word has been added (595) 3) cleanup some forrest doc (617) During review please note: 1) new file added, be sure to svn add it 2) LeaderZKServer was missing a getServerID override, added it 3) test the "conf" 4 letter word 4) test jmx, verify you can see the params 5) tests added for everything 6) be sure to regenerate the forrest docs and commit
          Patrick Hunt made changes -
          Attachment ZOOKEEPER-601.patch [ 12435038 ]
          Patrick Hunt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Patrick Hunt made changes -
          Link This issue incorporates ZOOKEEPER-595 [ ZOOKEEPER-595 ]
          Patrick Hunt made changes -
          Link This issue incorporates ZOOKEEPER-617 [ ZOOKEEPER-617 ]
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Patrick Hunt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12435038/ZOOKEEPER-601.patch
          against trunk revision 911716.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/117/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/117/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435038/ZOOKEEPER-601.patch against trunk revision 911716. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/117/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/117/console This message is automatically generated.
          Hide
          Henry Robinson added a comment -

          Patch looks great to me - appreciate the refactor of the *Server classes as well.

          Tests pass, 'conf' works and JMX works correctly.

          +1

          Show
          Henry Robinson added a comment - Patch looks great to me - appreciate the refactor of the *Server classes as well. Tests pass, 'conf' works and JMX works correctly. +1
          Henry Robinson made changes -
          Hadoop Flags [Reviewed]
          Hide
          Mahadev konar added a comment -

          this patch doesnt apply anymore. pat can you upload a new patch for trunk?

          Show
          Mahadev konar added a comment - this patch doesnt apply anymore. pat can you upload a new patch for trunk?
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Patrick Hunt added a comment -

          updated to compile against latest trunk

          Show
          Patrick Hunt added a comment - updated to compile against latest trunk
          Patrick Hunt made changes -
          Attachment ZOOKEEPER-601.patch [ 12438573 ]
          Patrick Hunt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12438573/ZOOKEEPER-601.patch
          against trunk revision 921853.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438573/ZOOKEEPER-601.patch against trunk revision 921853. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          I just committed this. thanks pat.

          Show
          Mahadev konar added a comment - I just committed this. thanks pat.
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #738 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #738 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/ )
          Patrick Hunt made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development