ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-598

LearnerHandler is misspelt in the thread's constructor

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.2.2
    • Fix Version/s: 3.2.2
    • Component/s: quorum
    • Labels:
      None

      Description

      Typo in thread constructor. Oops.

      1. ZOOKEEPER-598.patch
        0.7 kB
        Henry Robinson

        Activity

        Hide
        Henry Robinson added a comment -

        Trivial fix; plus did a grep -ir leaner src/* to check that I haven't done it anywhere else. Don't think tests are required for this one. Thanks Ben for pointing this out!

        Show
        Henry Robinson added a comment - Trivial fix; plus did a grep -ir leaner src/* to check that I haven't done it anywhere else. Don't think tests are required for this one. Thanks Ben for pointing this out!
        Hide
        Henry Robinson added a comment -

        Hudson will fail because this doesn't hit a test; this really isn't worth testing for.

        Show
        Henry Robinson added a comment - Hudson will fail because this doesn't hit a test; this really isn't worth testing for.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12426140/ZOOKEEPER-598.patch
        against trunk revision 884554.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/80/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/80/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426140/ZOOKEEPER-598.patch against trunk revision 884554. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/80/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/80/console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        +1, this is pretty simple patch. I have just committed it: revision 885394.

        Show
        Flavio Junqueira added a comment - +1, this is pretty simple patch. I have just committed it: revision 885394.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #565 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/565/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #565 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/565/ )

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development