ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-589

When create a znode, a NULL ACL parameter cannot be accepted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux

    • Hadoop Flags:
      Reviewed
    • Tags:
      Zookeeper C Client

      Description

      In the comments of client C API which associated with creating znode, eg. zoo_acreate, it is said that the initial ACL of the node "if null, the ACL of the parent will be used". However, the it doesn't work. When execute this kind of request at the server side, it raises InvalidACLException. The source code show that, the function fixupACL return false when it get a null ACL.

        Activity

        Hide
        Benjamin Reed added a comment -

        i think we should fix the client docs to reflect this behavior. "ACL of the parent" is a bit ambiguous if the parent's ACL changes after the create. it also will be problematic when we do federated ZooKeeper.

        Show
        Benjamin Reed added a comment - i think we should fix the client docs to reflect this behavior. "ACL of the parent" is a bit ambiguous if the parent's ACL changes after the create. it also will be problematic when we do federated ZooKeeper.
        Hide
        Benjamin Reed added a comment -

        thanx for catching this eric!

        Show
        Benjamin Reed added a comment - thanx for catching this eric!
        Hide
        Benjamin Reed added a comment -

        simple documentation patch. no tests needed.

        Show
        Benjamin Reed added a comment - simple documentation patch. no tests needed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12434699/ZOOKEEPER-524.patch
        against trunk revision 903483.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12434699/ZOOKEEPER-524.patch against trunk revision 903483. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/64/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 for the patch.

        Show
        Mahadev konar added a comment - +1 for the patch.
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks ben!

        Show
        Mahadev konar added a comment - I just committed this. thanks ben!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #690 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/690/)
        . changed ZOOKEEPER-489 in changelog to .

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #690 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/690/ ) . changed ZOOKEEPER-489 in changelog to .

          People

          • Assignee:
            Benjamin Reed
            Reporter:
            Qian Ye
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development