ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-587

client should log timeout negotiated with server

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: c client, java client
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client.

      1. ZOOKEEPER-587.patch
        3 kB
        Patrick Hunt
      2. ZOOKEEPER-587.patch
        2 kB
        Patrick Hunt

        Issue Links

          Activity

          Patrick Hunt created issue -
          Hide
          stack added a comment -

          If server changes the timeout on the client, yeah, for sure at least log it. Good stuff.

          Show
          stack added a comment - If server changes the timeout on the client, yeah, for sure at least log it. Good stuff.
          Hide
          Patrick Hunt added a comment -

          this patch adds negotiated timeout to both the c and java log messages

          I also add the destination server for the session to the java message (already on c log message)

          Show
          Patrick Hunt added a comment - this patch adds negotiated timeout to both the c and java log messages I also add the destination server for the session to the java message (already on c log message)
          Patrick Hunt made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-587.patch [ 12425811 ]
          Patrick Hunt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Patrick Hunt [ phunt ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12425811/ZOOKEEPER-587.patch
          against trunk revision 882744.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425811/ZOOKEEPER-587.patch against trunk revision 882744. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          I should be logging this in the server log as well.

          Show
          Patrick Hunt added a comment - I should be logging this in the server log as well.
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Patrick Hunt added a comment -

          Updated server to log message.

          Note there are no tests for this - it's a logging change only. Already exercised by existing code.

          Show
          Patrick Hunt added a comment - Updated server to log message. Note there are no tests for this - it's a logging change only. Already exercised by existing code.
          Patrick Hunt made changes -
          Attachment ZOOKEEPER-587.patch [ 12425919 ]
          Patrick Hunt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12425919/ZOOKEEPER-587.patch
          against trunk revision 882744.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425919/ZOOKEEPER-587.patch against trunk revision 882744. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          +1 the patch looks good.
          Though we sshould add apis for getting the sesssion timeout. In c we have zoo_recv_timeout (which sadly doesnt have any docs on it) but in java we dont have any. We should add it and document saying that the session timeout is negotiated and how and why. This could be another jira!

          Show
          Mahadev konar added a comment - +1 the patch looks good. Though we sshould add apis for getting the sesssion timeout. In c we have zoo_recv_timeout (which sadly doesnt have any docs on it) but in java we dont have any. We should add it and document saying that the session timeout is negotiated and how and why. This could be another jira!
          Patrick Hunt made changes -
          Link This issue is related to ZOOKEEPER-593 [ ZOOKEEPER-593 ]
          Hide
          Patrick Hunt added a comment -

          Added ZOOKEEPER-593 which addresses the issue Mahadev mentioned - good catch!

          Show
          Patrick Hunt added a comment - Added ZOOKEEPER-593 which addresses the issue Mahadev mentioned - good catch!
          Hide
          Benjamin Reed added a comment -

          +1 looks good.

          Show
          Benjamin Reed added a comment - +1 looks good.
          Benjamin Reed made changes -
          Hadoop Flags [Reviewed]
          Hide
          Mahadev konar added a comment -

          I just committed this. thanks pat.

          Show
          Mahadev konar added a comment - I just committed this. thanks pat.
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #625 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #625 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/ )
          Patrick Hunt made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Patrick Hunt made changes -
          Labels logging

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development