[ZOOKEEPER-568] SyncRequestProcessor snapping too frequently - counts non-log events as log events

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.1
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Patrick D. Hunt
• Reporter: Patrick D. Hunt
• Created: 03/Nov/09 01:38
• Updated: 15/Mar/19 21:40
• Resolved: 07/Nov/09 08:08

Description

Noticed the following issues in SyncRequestProcessor

1) logCount is incremented even for non-log events (say getData)
txnlog should return indication if request was logged or not (if hdr ==null it returns)

also:

2) move r.nextInt below logCount++ (ie if an actual log event)
3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)

Issue Links

• is related to: ZOOKEEPER-3316 Remove unused code in SyncRequestProcessor