ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-568

SyncRequestProcessor snapping too frequently - counts non-log events as log events

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Noticed the following issues in SyncRequestProcessor

      1) logCount is incremented even for non-log events (say getData)
      txnlog should return indication if request was logged or not (if hdr ==null it returns)

      also:

      2) move r.nextInt below logCount++ (ie if an actual log event)
      3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)

        Activity

        Patrick Hunt created issue -
        Patrick Hunt made changes -
        Field Original Value New Value
        Assignee Patrick Hunt [ phunt ]
        Patrick Hunt made changes -
        Attachment ZOOKEEPER-568.patch [ 12424223 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Benjamin Reed made changes -
        Hadoop Flags [Reviewed]
        Benjamin Reed made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development