ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-568

SyncRequestProcessor snapping too frequently - counts non-log events as log events

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Noticed the following issues in SyncRequestProcessor

      1) logCount is incremented even for non-log events (say getData)
      txnlog should return indication if request was logged or not (if hdr ==null it returns)

      also:

      2) move r.nextInt below logCount++ (ie if an actual log event)
      3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent)

        Activity

        Hide
        Patrick Hunt added a comment -

        move traceMask into isTraceEnabled check

        Show
        Patrick Hunt added a comment - move traceMask into isTraceEnabled check
        Hide
        Benjamin Reed added a comment -

        i think that r.nextInt is in the right place. we should document why it is there. (so that all the replicas aren't snap shotting at the same time.)

        apart from not counting the read only requests, we should also process them immediately if there are no pending writes.

        Show
        Benjamin Reed added a comment - i think that r.nextInt is in the right place. we should document why it is there. (so that all the replicas aren't snap shotting at the same time.) apart from not counting the read only requests, we should also process them immediately if there are no pending writes.
        Hide
        Patrick Hunt added a comment -

        this patch addressed the desc/comments. No tests as it's really an optimization.

        Show
        Patrick Hunt added a comment - this patch addressed the desc/comments. No tests as it's really an optimization.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12424223/ZOOKEEPER-568.patch
        against trunk revision 831486.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424223/ZOOKEEPER-568.patch against trunk revision 831486. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/49/console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        +1 great job pat!

        Show
        Benjamin Reed added a comment - +1 great job pat!
        Hide
        Benjamin Reed added a comment -

        Committed revision 833639.

        Show
        Benjamin Reed added a comment - Committed revision 833639.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #522 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #522 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/ )

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development