ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-566

"reqs" four letter word (command port) returns no information

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Committed revision 835515.

      Description

      the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.

      we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

        Issue Links

          Activity

          Patrick Hunt created issue -
          Hide
          Patrick Hunt added a comment -

          this patch removes the "reqs" command. at some point the code was refactored in such a way
          that this information was no longer available.

          also fixed the dump command to output sessionid as hex

          Added more detailed "cons" information - information on connections
          added "srvr" command that just shows server information
          added crst which resets the connection stat information (similar to srst for server stats)

          Show
          Patrick Hunt added a comment - this patch removes the "reqs" command. at some point the code was refactored in such a way that this information was no longer available. also fixed the dump command to output sessionid as hex Added more detailed "cons" information - information on connections added "srvr" command that just shows server information added crst which resets the connection stat information (similar to srst for server stats)
          Patrick Hunt made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-566.patch [ 12424451 ]
          Patrick Hunt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Patrick Hunt [ phunt ]
          Patrick Hunt made changes -
          Link This issue incorporates ZOOKEEPER-573 [ ZOOKEEPER-573 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12424451/ZOOKEEPER-566.patch
          against trunk revision 833938.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424451/ZOOKEEPER-566.patch against trunk revision 833938. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/console This message is automatically generated.
          Benjamin Reed made changes -
          Hadoop Flags [Reviewed]
          Benjamin Reed made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Release Note Committed revision 835515.
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #536 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/536/)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #536 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/536/ )
          Patrick Hunt made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          12d 1h 50m 1 Patrick Hunt 10/Nov/09 07:18
          Patch Available Patch Available Resolved Resolved
          2d 12h 36m 1 Benjamin Reed 12/Nov/09 19:54
          Resolved Resolved Closed Closed
          133d 21h 30m 1 Patrick Hunt 26/Mar/10 17:25

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development