ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-560

inefficient request handling in NIOServerCnxn

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      the server doIO code, specifically for read is inefficiently handling requests.

      dio does the following for reads

      if new request received: read length and return
      else read request body and return
      ....

      as a result we poll the selector twice for each request from a client.

      we should just read the request fully, reducing selector polling by half

        Issue Links

          Activity

          Patrick Hunt created issue -
          Patrick Hunt made changes -
          Field Original Value New Value
          Link This issue is part of ZOOKEEPER-558 [ ZOOKEEPER-558 ]
          Hide
          Patrick Hunt added a comment -

          this is part of the patch for ZOOKEEPER-558 (same general region/code)

          Show
          Patrick Hunt added a comment - this is part of the patch for ZOOKEEPER-558 (same general region/code)
          Hide
          Patrick Hunt added a comment -

          Fixed as part of ZOOKEEPER-558

          Show
          Patrick Hunt added a comment - Fixed as part of ZOOKEEPER-558
          Patrick Hunt made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Assignee Patrick Hunt [ phunt ]
          Resolution Fixed [ 1 ]
          Patrick Hunt made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development