Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.2.2, 3.3.0
    • Component/s: contrib-bindings
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
      over the lifetime of the python application.

      In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
      the session btw calls) this is an issue.

      it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
      dynamic growth/shrinkage of the handle list.

      Also see ZOOKEEPER-540

        Issue Links

          Activity

          Patrick Hunt created issue -
          Hide
          Henry Robinson added a comment -

          This patch ups the limit of concurrently active connections to 32768, and allocates these handles dynamically in increasing powers of two.

          Handles are re-used when they are correctly closed. This involves an O scan of the handle array, but I think this is preferable to the overhead of managing linked lists with O(1) lookup.

          Tests are included.

          Show
          Henry Robinson added a comment - This patch ups the limit of concurrently active connections to 32768, and allocates these handles dynamically in increasing powers of two. Handles are re-used when they are correctly closed. This involves an O scan of the handle array, but I think this is preferable to the overhead of managing linked lists with O(1) lookup. Tests are included.
          Henry Robinson made changes -
          Field Original Value New Value
          Attachment ZOOKEEPER-541.patch [ 12421470 ]
          Henry Robinson made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12421470/ZOOKEEPER-541.patch
          against trunk revision 822065.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/1/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421470/ZOOKEEPER-541.patch against trunk revision 822065. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/1/console This message is automatically generated.
          Hide
          Henry Robinson added a comment -

          This patch requires ZOOKEEPER-510 to be committed.

          Show
          Henry Robinson added a comment - This patch requires ZOOKEEPER-510 to be committed.
          Hide
          Henry Robinson added a comment -

          Restarting Hudson now that ZOOKEEPER-510 has gone in.

          Show
          Henry Robinson added a comment - Restarting Hudson now that ZOOKEEPER-510 has gone in.
          Henry Robinson made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          Hide
          Patrick Hunt added a comment -

          Henry, you want to make this "patch available", not "in progress". I seem to be locked out of doing that otw I would fix it.

          Show
          Patrick Hunt added a comment - Henry, you want to make this "patch available", not "in progress". I seem to be locked out of doing that otw I would fix it.
          Henry Robinson made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12421470/ZOOKEEPER-541.patch
          against trunk revision 823371.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421470/ZOOKEEPER-541.patch against trunk revision 823371. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          +1 Looks good. Tests look good to me as well.

          Show
          Patrick Hunt added a comment - +1 Looks good. Tests look good to me as well.
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #497 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/497/)
          . zkpython limited to 256 handles

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #497 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/497/ ) . zkpython limited to 256 handles
          Patrick Hunt made changes -
          Fix Version/s 3.2.2 [ 12314335 ]
          Patrick Hunt made changes -
          Link This issue incorporates ZOOKEEPER-540 [ ZOOKEEPER-540 ]
          Patrick Hunt made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Henry Robinson
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development