ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-535

ivy task does not enjoy being defined twice (build error)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Ant resolves the same dependencies multiple times if multiple targets are run on the command line:

      "ant b c", where b and c both depend on a, results in a being executed twice. However if you have a
      target d which depends on both b and c, "ant d" will only result in a being executed once.

      say "ant jar compile-test" is run, this will currently fail as ivy-init is run twice, resulting in the taskdef failing.

      Rather we need a guard on the ivy-init target itself to ensure it isn't run twice.

      ie: put an unless attrib on ivy-init, then set that property in the body of the target

        Activity

        Patrick Hunt created issue -
        Hide
        Patrick Hunt added a comment -

        this patch ensures that ivy taskdef only run once

        also adds a utility target for hudson to make building there more efficient.

        Show
        Patrick Hunt added a comment - this patch ensures that ivy taskdef only run once also adds a utility target for hudson to make building there more efficient.
        Patrick Hunt made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-535.patch [ 12420473 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mahadev konar added a comment -

        the patch looks good... I just committed this. thanks pat.

        Show
        Mahadev konar added a comment - the patch looks good... I just committed this. thanks pat.
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #477 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/477/)
        . ivy task does not enjoy being defined twice (build error) (phunt via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #477 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/477/ ) . ivy task does not enjoy being defined twice (build error) (phunt via mahadev)
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development