ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-529

Use Ivy to pull dependencies and also generate pom

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      using ivy for the build. Pulling all the dependent jars using ivy.

      Description

      Integrate Ivy into the build. Generate Pom and signed jars to allow zk jars to be officially deployed to a maven repo.

      1. ZOOKEEPER-529.patch
        43 kB
        Patrick Hunt
      2. ZOOKEEPER-529.patch
        44 kB
        Patrick Hunt
      3. ZOOKEEPER-529.patch
        45 kB
        Patrick Hunt

        Issue Links

          Activity

          Hide
          Patrick Hunt added a comment -

          this patch:

          1) adds ivy support
          2) removes src/java/lib/*.jar from svn, these jars are now d/l automatically by ivy at build time
          3) log4j/jline are included in the rel package, but not things like junit (which will be d/l by ivy if tests run on package)
          4) remove legacy zookeeper-dev.jar in favor of a single, std, zookeeper-<version>.jar in build directory
          5) bit of housecleaning on build.xml

          also:

          a) pom file is now generated, by ivy, for zookeeper jar, included in release package
          b) checksums are generated for zk jar - they are included in release archive, allowing us to deploy release to maven repo

          contrib builds have not been moved to ivy (same as before)

          Show
          Patrick Hunt added a comment - this patch: 1) adds ivy support 2) removes src/java/lib/*.jar from svn, these jars are now d/l automatically by ivy at build time 3) log4j/jline are included in the rel package, but not things like junit (which will be d/l by ivy if tests run on package) 4) remove legacy zookeeper-dev.jar in favor of a single, std, zookeeper-<version>.jar in build directory 5) bit of housecleaning on build.xml also: a) pom file is now generated, by ivy, for zookeeper jar, included in release package b) checksums are generated for zk jar - they are included in release archive, allowing us to deploy release to maven repo contrib builds have not been moved to ivy (same as before)
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420095/ZOOKEEPER-529.patch
          against trunk revision 815574.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 25 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to cause Findbugs to fail.

          -1 release audit. The applied patch generated 181 release audit warnings (more than the trunk's current 176 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/8/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/8/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/8/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420095/ZOOKEEPER-529.patch against trunk revision 815574. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs to fail. -1 release audit. The applied patch generated 181 release audit warnings (more than the trunk's current 176 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/8/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/8/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/8/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          a couple small changes, otw same as last patch:

          1) fix notice text to be in line with apache current requirement for NOTICE.txt
          2) ivy jar was being copied into src/java/lib in package, now excluded.

          also, forgot to note: as part of defining ivy.xml I've moved us to junit 4.7 (was 4.4, 4.6 was approved as ZOOKEEPER-476 but I will close that as it's superseded by this.)

          Show
          Patrick Hunt added a comment - a couple small changes, otw same as last patch: 1) fix notice text to be in line with apache current requirement for NOTICE.txt 2) ivy jar was being copied into src/java/lib in package, now excluded. also, forgot to note: as part of defining ivy.xml I've moved us to junit 4.7 (was 4.4, 4.6 was approved as ZOOKEEPER-476 but I will close that as it's superseded by this.)
          Hide
          Patrick Hunt added a comment -

          same as previous patch except fixed findbugs.

          Show
          Patrick Hunt added a comment - same as previous patch except fixed findbugs.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420112/ZOOKEEPER-529.patch
          against trunk revision 815574.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 25 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          -1 release audit. The applied patch generated 181 release audit warnings (more than the trunk's current 176 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420112/ZOOKEEPER-529.patch against trunk revision 815574. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 181 release audit warnings (more than the trunk's current 176 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/10/console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          the release audit warning increase is just due to adding pom file and checksum files.

          Please review and commit this asap.

          Show
          Patrick Hunt added a comment - the release audit warning increase is just due to adding pom file and checksum files. Please review and commit this asap.
          Hide
          Mahadev konar added a comment -

          this is great... will make our build really clean – some comments/questions:

          • I see changes to
          --- src/recipes/lock/src/c/tests/zkServer.sh
          --- src/contrib/zkpython/src/test/zkServer.sh
          

          Doesnt src/c/tests/zkServer.sh need changes? We should combine all these files into one, but that is another jira.

          • also, I ran the tests twice and it succeded but it left a process running on my machine after the tests were done running
            java -cp :../../..//build/classes:../../..//conf:../../..//build/lib/jline-0.9.94.jar:../../..//build/lib/log4j-1.2.15.jar:../../..//src/java/lib/ivy-2.1.0-rc2.jar:../../..//src/java/lib/jline-0.9.94.jar:../../..//src/java/lib/junit-4.4.jar:../../..//src/java/lib/log4j-1.2.15.jar org.apache.zookeeper.server.ZooKeeperServerMain 22182 /tmp/zkdata
            

            Am not sure that if I accidentally might have killed something or not (both times). Ill re verify this. Do you see any such problem?

          Other than that the patch looks good to go... sorry about the delay in reviewing...

          Show
          Mahadev konar added a comment - this is great... will make our build really clean – some comments/questions: I see changes to --- src/recipes/lock/src/c/tests/zkServer.sh --- src/contrib/zkpython/src/test/zkServer.sh Doesnt src/c/tests/zkServer.sh need changes? We should combine all these files into one, but that is another jira. also, I ran the tests twice and it succeded but it left a process running on my machine after the tests were done running java -cp :../../.. //build/classes:../../..//conf:../../..//build/lib/jline-0.9.94.jar:../../..//build/lib/log4j-1.2.15.jar:../../..//src/java/lib/ivy-2.1.0-rc2.jar:../../..//src/java/lib/jline-0.9.94.jar:../../..//src/java/lib/junit-4.4.jar:../../..//src/java/lib/log4j-1.2.15.jar org.apache.zookeeper.server.ZooKeeperServerMain 22182 /tmp/zkdata Am not sure that if I accidentally might have killed something or not (both times). Ill re verify this. Do you see any such problem? Other than that the patch looks good to go... sorry about the delay in reviewing...
          Hide
          Patrick Hunt added a comment -

          There are changes to 4 zkServer.sh files, one of which is in c tests (perhaps you missed it, check the patch file)

          I did notice that zkPython zkServer.sh doesn't have any "stop" code, so I suspect that's the issue.

          I suggest you enter a couple jiras, one on zkPython and another that we should clean up this proliferation of zkServer.sh files.

          Please commit this asap.

          Show
          Patrick Hunt added a comment - There are changes to 4 zkServer.sh files, one of which is in c tests (perhaps you missed it, check the patch file) I did notice that zkPython zkServer.sh doesn't have any "stop" code, so I suspect that's the issue. I suggest you enter a couple jiras, one on zkPython and another that we should clean up this proliferation of zkServer.sh files. Please commit this asap.
          Hide
          Mahadev konar added a comment -

          good.... I dont know how I missed the first one.... you might be right on the second one... We can fix that in ZOOKEEPER-414.
          ill commit this.

          Show
          Mahadev konar added a comment - good.... I dont know how I missed the first one.... you might be right on the second one... We can fix that in ZOOKEEPER-414 . ill commit this.
          Hide
          Mahadev konar added a comment -

          I just committed this. thanks pat.

          Show
          Mahadev konar added a comment - I just committed this. thanks pat.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #477 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/477/)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #477 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/477/ )

            People

            • Assignee:
              Patrick Hunt
              Reporter:
              Patrick Hunt
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development