ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-518

DEBUG message for outstanding proposals in leader should be moved to trace.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0
    • Fix Version/s: 3.2.1, 3.3.0
    • Component/s: tests
    • Labels:
    • Environment:

      Non specific

    • Hadoop Flags:
      Reviewed
    • Release Note:
      The released of this module should be done only in apache org as this module is move to the debug to trace since it will cause really high latenciesinin response times from zookeeper services in case folks want to use DEBUGlogging for servers.

      Description

      this is the code in Leader.java

       if (LOG.isDebugEnabled()) {
                  LOG.debug("Ack zxid: 0x" + Long.toHexString(zxid));
                  for (Proposal p : outstandingProposals.values()) {
                      long packetZxid = p.packet.getZxid();
                      LOG.debug("outstanding proposal: 0x"
                              + Long.toHexString(packetZxid));
                  }
                  LOG.debug("outstanding proposals all");
              }
      
      

      We should move this debug to trace since it will cause really high latencies in response times from zookeeper servers in case folks want to use DEBUG logging for servers.

        Activity

        Patrick Hunt made changes -
        Labels logging
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Prasad Gawande made changes -
        Affects Version/s 4.0.0 [ 12313382 ]
        Affects Version/s 3.2.0 [ 12313491 ]
        Affects Version/s 3.1.1 [ 12313649 ]
        Environment Non specific
        Issue Type Bug [ 1 ] Test [ 6 ]
        Component/s tests [ 12312427 ]
        Component/s server [ 12312382 ]
        Release Note The released of this module should be done only in apache org as this module is move to the debug to trace since it will cause really high latenciesinin response times from zookeeper services in case folks want to use DEBUGlogging for servers.
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Patrick Hunt made changes -
        Attachment ZOOKEEPER-518.patch [ 12417755 ]
        Patrick Hunt made changes -
        Affects Version/s 3.2.0 [ 12313491 ]
        Affects Version/s 3.1.1 [ 12313649 ]
        Component/s server [ 12312382 ]
        Patrick Hunt made changes -
        Field Original Value New Value
        Assignee Mahadev konar [ mahadev ] Patrick Hunt [ phunt ]
        Fix Version/s 3.2.1 [ 12314068 ]
        Mahadev konar created issue -

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development