[ZOOKEEPER-505] testAsyncCreateClose is badly broken

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: contrib-bookkeeper
• Assignee: Utkarsh Srivastava
• Reporter: Utkarsh Srivastava
• Created: 08/Aug/09 20:57
• Updated: 26/Mar/10 17:25
• Resolved: 26/Jan/10 23:17

Description

The test case testAsyncCreateClose is badly broken. I was wondering why all the unit tests are passing inspite of having found so many different problems with LedgerManagementProcessor.

There is a big try-catch block sitting in the test case that catches all exception, prints their stack trace, and exits, thereby allowing the test to pass. In general, unit tests shouldnt catch exceptions unless it is something you are expecting that will happen.

Another problem is that the same ControlObject is used for synchronization throughout. Since we already have the problem of callbacks being called multiple times (ZOOKEEPER-502), notify() on the control object is called too many times, resulting in the unit test not waiting for certain callbacks.

Thus the test never waits for the asyncOpenLedger() to finish, and hence still succeeds. I believe asyncOpenLedger() has never worked right.

Issue Links

• is part of: ZOOKEEPER-507 BookKeeper client re-write