Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-500

Async methods shouldnt throw exceptions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: contrib-bookkeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Async methods like asyncLedgerCreate and Open shouldnt be throwing InterruptedException and BKExceptions.

      The present method signatures lead to messy application code since one is forced to have error handling code in 2 places: inside the callback to handler a non-OK return code, and outside for handling the exceptions thrown by the call.

      There should be only one way to indicate error conditions, and that should be through a non-ok return code to the callback.

        Attachments

        1. ZOOKEEPER-500.patch
          4 kB
          Flavio Junqueira

          Activity

            People

            • Assignee:
              fpj Flavio Junqueira
              Reporter:
              utkarsh Utkarsh Srivastava
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: