ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-495

c client logs an invalid error when zookeeper_init is called with chroot

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.3.0
    • Component/s: c client
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The C client logs this error message when zookeeper_init is called with chroot.

      2009-08-03 18:14:29,130:6624(0x5e66e950):ZOO_ERROR@sub_string@730: server path does not include chroot path /chroot

      I'll attach a simple program to reproduce this.

      Thanks!
      --Michi

      1. chroot.cc
        0.3 kB
        Michi Mutsuzaki
      2. chroot.log
        1 kB
        Michi Mutsuzaki
      3. ZOOKEEPER-495.patch
        2 kB
        Patrick Hunt

        Activity

        Michi Mutsuzaki created issue -
        Hide
        Michi Mutsuzaki added a comment -

        Here is a simple program to reproduce the issue and corresponding log.

        --Michi

        Show
        Michi Mutsuzaki added a comment - Here is a simple program to reproduce the issue and corresponding log. --Michi
        Michi Mutsuzaki made changes -
        Field Original Value New Value
        Attachment chroot.cc [ 12415379 ]
        Attachment chroot.log [ 12415380 ]
        Mahadev konar made changes -
        Fix Version/s 3.3.0 [ 12313976 ]
        Hide
        Patrick Hunt added a comment -

        I updated the code to only output for non-session events. session event's don't have paths (zero len str)

        No tests as the current tests were causing this error to be output, I verified that the log is not being output in this case.

        Show
        Patrick Hunt added a comment - I updated the code to only output for non-session events. session event's don't have paths (zero len str) No tests as the current tests were causing this error to be output, I verified that the log is not being output in this case.
        Patrick Hunt made changes -
        Attachment ZOOKEEPER-495.patch [ 12431177 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Patrick Hunt [ phunt ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12431177/ZOOKEEPER-495.patch
        against trunk revision 902320.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/51/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/51/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/51/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431177/ZOOKEEPER-495.patch against trunk revision 902320. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/51/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/51/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/51/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good.

        Show
        Mahadev konar added a comment - +1 the patch looks good.
        Hide
        Mahadev konar added a comment -

        +1 for the patch. I just committed this. thanks pat.

        Show
        Mahadev konar added a comment - +1 for the patch. I just committed this. thanks pat.
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #680 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #680 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/ )
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Patrick Hunt made changes -
        Labels logging
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        172d 5h 58m 1 Patrick Hunt 23/Jan/10 00:18
        Patch Available Patch Available Resolved Resolved
        3d 2h 53m 1 Mahadev konar 26/Jan/10 03:11
        Resolved Resolved Closed Closed
        59d 14h 13m 1 Patrick Hunt 26/Mar/10 17:24

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development