[ZOOKEEPER-4738] Clean test cases by refactoring assertFalse(equals()) with assertNotEquals - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.10.0
Component/s: None
Labels:
- pull-request-available

Description

I am working on research that investigates test smell refactoring in which we identify alternative implementations of test cases, study how commonly used these refactorings are, and assess how acceptable they are in practice.

This smell occurs when inappropriate assertions are used, while there exist better alternatives. For example, assertFalse(x.equals( y )); can be refactored using assertNotEquals(x, y);.

I would like to get your feedback on this particular test smell and its refactoring. Thanks in advance for your input.