ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-447

zkServer.sh doesn't allow different config files to be specified on the command line

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.1, 3.2.0
    • Fix Version/s: 3.2.1, 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Unless I'm missing something, you can change the directory that the zoo.cfg file is in by setting ZOOCFGDIR but not the name of the file itself.

      I find it convenient myself to specify the config file on the command line, but we should also let it be specified by environment variable.

      1. ZOOKEEPER-447.patch
        0.8 kB
        Henry Robinson

        Activity

        Hide
        Henry Robinson added a comment -

        This tiny patch to zkEnv.sh and zkServer.sh has these improvements:

        1. set ZOOCFG in the environment and it will be picked up
        2. specify a config file as the second argument to zkServer.sh

        No tests included, obviously

        Show
        Henry Robinson added a comment - This tiny patch to zkEnv.sh and zkServer.sh has these improvements: 1. set ZOOCFG in the environment and it will be picked up 2. specify a config file as the second argument to zkServer.sh No tests included, obviously
        Hide
        Benjamin Reed added a comment -

        +1 good idea

        Show
        Benjamin Reed added a comment - +1 good idea
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12411795/ZOOKEEPER-447.patch
        against trunk revision 788539.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12411795/ZOOKEEPER-447.patch against trunk revision 788539. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Marking for 3.3, we may also want to consider for 3.2.1 (this is not strictly a bug however)

        Show
        Patrick Hunt added a comment - Marking for 3.3, we may also want to consider for 3.2.1 (this is not strictly a bug however)
        Hide
        Mahadev konar added a comment -

        this looks ready to go in since 3.2 is out. Ill wait until we decide on what we want in 3.2.1.

        Show
        Mahadev konar added a comment - this looks ready to go in since 3.2 is out. Ill wait until we decide on what we want in 3.2.1.
        Hide
        Patrick Hunt added a comment -

        +1, thanks Henry! Committed to 3.2.1 and 3.3

        Show
        Patrick Hunt added a comment - +1, thanks Henry! Committed to 3.2.1 and 3.3
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #405 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/405/)
        . zkServer.sh doesn't allow different config files to be specified on the command line

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #405 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/405/ ) . zkServer.sh doesn't allow different config files to be specified on the command line

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development