ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-444

perms definition for PERMS_ALL differ in C and java

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Changed PERMS.ALL definition in ZooDefs in java to include ADMIN. This changes the definition of OPEN_ACL_UNSAFE to have admin perms.

      Description

      the perms_all definition in Java is PERMS.ALL and does not include ADMIN perms but in c the PERMS_ALL def includes the ADMIN perms. We should make it consistent to include or not include the admin perms in both c and java.

      1. ZOOKEEPER-444.patch
        0.8 kB
        Mahadev konar

        Activity

        Mahadev konar created issue -
        Hide
        Mahadev konar added a comment -

        this patch adds admin to ALL in java.

        Show
        Mahadev konar added a comment - this patch adds admin to ALL in java.
        Mahadev konar made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-444.patch [ 12410884 ]
        Mahadev konar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12410884/ZOOKEEPER-444.patch
        against trunk revision 785019.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410884/ZOOKEEPER-444.patch against trunk revision 785019. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/console This message is automatically generated.
        Hide
        Benjamin Reed added a comment -

        +1 brilliant!

        Show
        Benjamin Reed added a comment - +1 brilliant!
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks ben for the brilliant review .

        Show
        Mahadev konar added a comment - I just committed this. thanks ben for the brilliant review .
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Incompatible change, Reviewed]
        Release Note Changed PERMS.ALL definition in ZooDefs in java to include ADMIN. This changes the definition of OPEN_ACL_UNSAFE to have admin perms.
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #350 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/350/)
        . perms definition for PERMS_ALL differ in C and java (mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #350 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/350/ ) . perms definition for PERMS_ALL differ in C and java (mahadev)
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development