[ZOOKEEPER-4381] Remove magic string in QuorumPeerConfig

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Wenjun Ruan
• Created: 21/Sep/21 04:00
• Updated: 17/Jan/22 11:51

Description

Currently, we write magic string in QuorumPeerConfig, this may not be a good practice.
https://stackoverflow.com/questions/47882/what-is-a-magic-number-and-why-is-it-bad

if (key.equals("dataDir")) {
     dataDir = vff.create(value);
} else if (key.equals("dataLogDir")) {
     dataLogDir = vff.create(value);
}

It might be better to maintain these configs string in a single class

Issue Links

• links to: GitHub Pull Request #1759