Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Patch with a variety of documentation updates. Some new content for getting started based on my experience trying it out, plus some typo fixes, etc.

      1. ZOOKEEPER-437.patch
        8 kB
        Mahadev konar
      2. ZOOKEEPER-437.patch
        8 kB
        Grant Ingersoll

        Activity

        Hide
        Grant Ingersoll added a comment -

        Some suggested docs changes/improvements

        Show
        Grant Ingersoll added a comment - Some suggested docs changes/improvements
        Hide
        Mahadev konar added a comment -

        +1 looks good..

        Show
        Mahadev konar added a comment - +1 looks good..
        Hide
        Mahadev konar added a comment -

        trying hudson again.

        Show
        Mahadev konar added a comment - trying hudson again.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12410052/ZOOKEEPER-437.patch
        against trunk revision 782792.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/108/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/108/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410052/ZOOKEEPER-437.patch against trunk revision 782792. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/108/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/108/console This message is automatically generated.
        Hide
        Grant Ingersoll added a comment -

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        It's a documentation patch. The one spot that it touches code is to better format the ZooKeeperMain help output

        Show
        Grant Ingersoll added a comment - -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. It's a documentation patch. The one spot that it touches code is to better format the ZooKeeperMain help output
        Hide
        Mahadev konar added a comment -

        the patch conflicted because of the last commit, so I made some changes and uploaded a new patch.

        Show
        Mahadev konar added a comment - the patch conflicted because of the last commit, so I made some changes and uploaded a new patch.
        Hide
        Mahadev konar added a comment -

        rerunning through the hudson...

        Show
        Mahadev konar added a comment - rerunning through the hudson...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12410239/ZOOKEEPER-437.patch
        against trunk revision 783096.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410239/ZOOKEEPER-437.patch against trunk revision 783096. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks grant.

        Show
        Mahadev konar added a comment - I just committed this. thanks grant.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #343 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/343/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #343 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/343/ )

          People

          • Assignee:
            Grant Ingersoll
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development