[ZOOKEEPER-4258] Improve stream use in QuorumCnxManager

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.6.2
• Component/s: quorum, server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: IcySanwitch
• Created: 24/Mar/21 02:32
• Updated: 25/Mar/21 10:04

Description

I find three issues about stream object use in QuorumCnxManager. They are not bugs but may belong to bad practices.

• Mismatch stream creation in RecvWorker and SendWorker.
  DataInputStream in RecvWorker is created by

  new DataInputStream(new BufferedInputStream(sock.getInputStream()))
  

  While DataOutputStream in SendWorker is created by

  new DataOutputStream(sock.getOutputStream)
  

• Stream instances are never closed in RecvWorker and SendWorker.

• RecvWorker and SendWorker are initialized before removing old ones.

Issue Links

• links to: GitHub Pull Request #1650
• links to: GitHub Pull Request #1651