ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-413

two flaws need addressing in the c tests that can cause false positive failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: c client, tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server
      2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to
      have some limit on the number of iterations (other than just the test, which may never return false), also the
      loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use.

        Activity

        Patrick Hunt created issue -
        Patrick Hunt made changes -
        Field Original Value New Value
        Component/s tests [ 12312427 ]
        Mahadev konar made changes -
        Fix Version/s 3.3.0 [ 12313976 ]
        Fix Version/s 3.2.0 [ 12313491 ]
        Patrick Hunt made changes -
        Assignee Mahadev konar [ mahadev ] Patrick Hunt [ phunt ]
        Patrick Hunt made changes -
        Attachment ZOOKEEPER-413.patch [ 12431380 ]
        Patrick Hunt made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development