ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-413

two flaws need addressing in the c tests that can cause false positive failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: c client, tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server
      2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to
      have some limit on the number of iterations (other than just the test, which may never return false), also the
      loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use.

        Activity

        Hide
        Mahadev konar added a comment -

        moving it to 3.3

        Show
        Mahadev konar added a comment - moving it to 3.3
        Hide
        Patrick Hunt added a comment -

        item 1) is already addressed - we start a single server for all c tests (new in 3.3.0), the script for starting the server
        now waits for the server to start (up to some max time of course).

        2) is still important to fix though

        Show
        Patrick Hunt added a comment - item 1) is already addressed - we start a single server for all c tests (new in 3.3.0), the script for starting the server now waits for the server to start (up to some max time of course). 2) is still important to fix though
        Hide
        Patrick Hunt added a comment -

        fixed the tests - small sleeps so we don't spin in the while loops.

        Show
        Patrick Hunt added a comment - fixed the tests - small sleeps so we don't spin in the while loops.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12431380/ZOOKEEPER-413.patch
        against trunk revision 902694.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431380/ZOOKEEPER-413.patch against trunk revision 902694. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good. I just committed this. thanks pat.

        Show
        Mahadev konar added a comment - +1 the patch looks good. I just committed this. thanks pat.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #680 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #680 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/ )

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development