[ZOOKEEPER-4029] improve the log of FileTxnLog#append method

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Ling Mao
• Created: 16/Dec/20 09:39
• Updated: 17/May/21 18:05

Description

We found the following logs that it's very confusing

2020-12-16 15:19:09,202 [myid:5] - WARN  [SyncThread:5:FileTxnLog@275] - Current zxid 858993459201 is <= 858993459203 for -10
2020-12-16 15:19:09,202 [myid:5] - WARN  [SyncThread:5:FileTxnLog@275] - Current zxid 858993459202 is <= 858993459203 for -10
2020-12-16 15:19:09,203 [myid:5] - WARN  [SyncThread:5:FileTxnLog@275] - Current zxid 858993459203 is <= 858993459203 for 5

The potential improvement may be:

if (hdr.getZxid() <= lastZxidSeen) {
    LOG.warn(
        "Current zxid {} is <= {} for operation {}",
        hdr.getZxid(),
        lastZxidSeen,
        Request.op2String(hdr.getType()));
} else {
    lastZxidSeen = hdr.getZxid();
}

 

Issue Links

• links to: GitHub Pull Request #1694