[ZOOKEEPER-3910] zkServer.sh code format is oldfashioned and chaotic

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.5.5, 3.5.6, 3.5.7, 3.6.1, 3.5.8
• Component/s: scripts
• Assignee: Unassigned
• Reporter: Diego Lucas Jiménez
• Created: 10/Aug/20 13:40
• Updated: 10/Aug/20 15:44

Description

Replaced old comparison of vars, usually used in sh.

Since the script is now pure bash, it's better to use more standard comparators to improve readability, like 

 

[ -z $var ] 

instead of

[ "x$var" = "x" ]

Also equalized a bit the indentation and format of "if" statements in the script.

This will improve readability, as pointed out above, and make it easier to maintain