Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      to implement jdiff

    • Hadoop Flags:
      Reviewed
    1. zookeeper-371.patch
      123 kB
      Giridharan Kesavan
    2. zookeeper-371.patch
      1.07 MB
      Giridharan Kesavan

      Issue Links

        Activity

        Hide
        gkesavan Giridharan Kesavan added a comment -

        this patch enables jdiff for zookeeper.
        Tnx!

        Show
        gkesavan Giridharan Kesavan added a comment - this patch enables jdiff for zookeeper. Tnx!
        Hide
        gkesavan Giridharan Kesavan added a comment -

        Mahadev,
        Could you please review this?
        tnx!

        Show
        gkesavan Giridharan Kesavan added a comment - Mahadev, Could you please review this? tnx!
        Hide
        breed Benjamin Reed added a comment -

        shouldn't this be generated rather than checked in?

        Show
        breed Benjamin Reed added a comment - shouldn't this be generated rather than checked in?
        Hide
        gkesavan Giridharan Kesavan added a comment -

        Please correct me if I'm wrong.

        patch contains api for 3.1.1(zookeeper_3.1.1.xml) and tha api-xml target would generate the api doc for 3.2.0(trunk version)
        This 3.1.1 api doc is required to compare the api changes b/w 3.1.1 and 3.2.0.

        Thanks,

        Show
        gkesavan Giridharan Kesavan added a comment - Please correct me if I'm wrong. patch contains api for 3.1.1(zookeeper_3.1.1.xml) and tha api-xml target would generate the api doc for 3.2.0(trunk version) This 3.1.1 api doc is required to compare the api changes b/w 3.1.1 and 3.2.0. Thanks,
        Hide
        mahadev Mahadev konar added a comment -

        giri,
        I think what ben meant was –
        run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?

        Show
        mahadev Mahadev konar added a comment - giri, I think what ben meant was – run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?
        Hide
        gkesavan Giridharan Kesavan added a comment - - edited

        run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?

        This patch that I submitted is to run during the nightly to show up any changes b/w 3.1.1 and 3.2.0.

        But I understand the requirement that we want this jdiff as part of the patch test process, that way we can say whether a patch has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon.

        tnx

        Show
        gkesavan Giridharan Kesavan added a comment - - edited run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go? This patch that I submitted is to run during the nightly to show up any changes b/w 3.1.1 and 3.2.0. But I understand the requirement that we want this jdiff as part of the patch test process, that way we can say whether a patch has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon. tnx
        Hide
        gkesavan Giridharan Kesavan added a comment -

        patch build stuck on hudson for more that 10Hrs. I killed the patch build.
        Resubmitting the patch to hudson.
        tnx

        Show
        gkesavan Giridharan Kesavan added a comment - patch build stuck on hudson for more that 10Hrs. I killed the patch build. Resubmitting the patch to hudson. tnx
        Hide
        mahadev Mahadev konar added a comment -

        +1 on the patch . I ll wait for hudson to run through it.

        Show
        mahadev Mahadev konar added a comment - +1 on the patch . I ll wait for hudson to run through it.
        Hide
        mahadev Mahadev konar added a comment -

        retrying hudson...

        Show
        mahadev Mahadev konar added a comment - retrying hudson...
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12405402/zookeeper-371.patch
        against trunk revision 765797.

        -1 @author. The patch appears to contain 48 @author tags which the ZooKeeper community has agreed to not allow in code contributions.

        +1 tests included. The patch appears to include 1 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        -1 release audit. The applied patch generated 109 release audit warnings (more than the trunk's current 105 warnings).

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/testReport/
        Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/artifact/trunk/current/releaseAuditDiffWarnings.txt
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12405402/zookeeper-371.patch against trunk revision 765797. -1 @author. The patch appears to contain 48 @author tags which the ZooKeeper community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 109 release audit warnings (more than the trunk's current 105 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/console This message is automatically generated.
        Hide
        mahadev Mahadev konar added a comment -

        giri can you take a look at this? is this expected?

        Show
        mahadev Mahadev konar added a comment - giri can you take a look at this? is this expected?
        Hide
        gkesavan Giridharan Kesavan added a comment -

        -1 for the release audit is expected as the jdiff is creating files on the fly; but for the author tags I think I should talk to Nigel
        tnx!

        Show
        gkesavan Giridharan Kesavan added a comment - -1 for the release audit is expected as the jdiff is creating files on the fly; but for the author tags I think I should talk to Nigel tnx!
        Hide
        gkesavan Giridharan Kesavan added a comment -

        I'm working on recreating this patch to exclude the jute package.
        -tnx

        Show
        gkesavan Giridharan Kesavan added a comment - I'm working on recreating this patch to exclude the jute package. -tnx
        Hide
        gkesavan Giridharan Kesavan added a comment -

        this patch excludes jute package for jdiff

        Show
        gkesavan Giridharan Kesavan added a comment - this patch excludes jute package for jdiff
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12406100/zookeeper-371.patch
        against trunk revision 766897.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        -1 release audit. The applied patch generated 142 release audit warnings (more than the trunk's current 105 warnings).

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/testReport/
        Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/current/releaseAuditDiffWarnings.txt
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12406100/zookeeper-371.patch against trunk revision 766897. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 142 release audit warnings (more than the trunk's current 105 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/console This message is automatically generated.
        Hide
        phunt Patrick Hunt added a comment -

        +1, looks great. I generated the release package and it looks good.

        Thanks Giri!

        Show
        phunt Patrick Hunt added a comment - +1, looks great. I generated the release package and it looks good. Thanks Giri!
        Hide
        phunt Patrick Hunt added a comment -

        Committed revision 767596

        Thanks Giri!

        Show
        phunt Patrick Hunt added a comment - Committed revision 767596 Thanks Giri!
        Hide
        hudson Hudson added a comment -

        Integrated in ZooKeeper-trunk #288 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/288/)
        . jdiff documentation included in build/release

        Show
        hudson Hudson added a comment - Integrated in ZooKeeper-trunk #288 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/288/ ) . jdiff documentation included in build/release

          People

          • Assignee:
            gkesavan Giridharan Kesavan
            Reporter:
            gkesavan Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development