[ZOOKEEPER-3633] AdminServer commands throw NPE when only secure client port is used

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.5, 3.5.6
• Fix Version/s: 3.6.0, 3.5.7
• Labels: pull-request-available
• Assignee: Mate Szalay-Beko
• Reporter: Mate Szalay-Beko
• Created: 28/Nov/19 16:08
• Updated: 14/Feb/20 15:23
• Resolved: 03/Dec/19 09:02

Description

thanks for Mike Smotritsky for reporting this bug!

when only secureClientPort is defined in the config and there is no regular clientPort, then both the stat and the conf commands result in 500 Server Error caused by NullPointerExceptions. The problem is that no serverCnxFactory is defined in the ZooKeeperServer in this case, we have only secureServerCnxnFactory.

see the attached stacktraces about the exceptions (reproduced on the current master branch)

The stat and conf admin commands should actually provide info about both secure and unsecure connections, and should handle the case when any of these are missing.

Issue Links

• links to: GitHub Pull Request #1161