[ZOOKEEPER-3487] Execution the same conditional statement twice in ZooTrace

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.4.11, 3.4.12, 3.4.13, 3.5.5, 3.4.14
• Component/s: server

Environment

Ubuntu 16.04.3 LTS
Open JDK version "1.8.0_191" build 25.191-b12

• Assignee: Unassigned
• Reporter: xiaoqin.fu
• Created: 02/Aug/19 10:55
• Updated: 28/Oct/19 14:25

Description

public static void logTraceMessage(Logger log, long mask, String msg) {
if (isTraceEnabled(log, mask))

{ log.trace(msg); }
}

static public void logQuorumPacket(Logger log, long mask,
char direction, QuorumPacket qp)
{
if (isTraceEnabled(log, mask)) { logTraceMessage(log, mask, direction + " " + LearnerHandler.packetToString(qp)); }
}

We should remove one of two "if (isTraceEnabled(log, mask))" conditional statements:

public static void logTraceMessage(Logger log, long mask, String msg) {
if (isTraceEnabled(log, mask)) { log.trace(msg); }

}
static public void logQuorumPacket(Logger log, long mask,
char direction, QuorumPacket qp)

{ logTraceMessage(log, mask, direction + " " + LearnerHandler.packetToString(qp)); }