Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.2.0
    • Component/s: contrib-zkfuse
    • Labels:
      None
    • Environment:

      gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)

    • Hadoop Flags:
      Reviewed

      Description

      I'm getting an error compiling zkfuse:

      g++ -DHAVE_CONFIG_H -I. -I.. -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/include -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/generated -I../include -I/usr/include -D_FILE_OFFSET_BITS=64 -D_REENTRANT -g -O2 -MT zkfuse.o -MD -MP -MF .deps/zkfuse.Tpo -c -o zkfuse.o zkfuse.cc
      zkfuse.cc: In function 'int main(int, char**)':
      zkfuse.cc:4282: error: 'String' does not name a type
      zkfuse.cc:4283: error: 'file' was not declared in this scope
      make[2]: *** [zkfuse.o] Error 1
      make[2]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse/src'
      make[1]: *** [all-recursive] Error 1
      make[1]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse'
      make: *** [all] Error 2

      4279 /**
      4280 * Initialize log4cxx
      4281 */
      4282 const String file("log4cxx.properties");
      4283 PropertyConfigurator::configureAndWatch( file, 5000 );
      4284 LOG_INFO(LOG, "Starting zkfuse");

      String is not standard, we should change it to std::string.

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #276 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/276/)
        . zkfuse uses non-standard String. (patrick hunt via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #276 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/276/ ) . zkfuse uses non-standard String. (patrick hunt via mahadev)
        Hide
        Mahadev konar added a comment -

        +1 for the patch . i just committed this. thanks pat.

        Show
        Mahadev konar added a comment - +1 for the patch . i just committed this. thanks pat.
        Hide
        Patrick Hunt added a comment -

        this fixes a C code gcc compiler warning, existing tests otw cover.

        Please review/commit this.

        Show
        Patrick Hunt added a comment - this fixes a C code gcc compiler warning, existing tests otw cover. Please review/commit this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12404895/ZOOKEEPER-347.patch
        against trunk revision 762602.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404895/ZOOKEEPER-347.patch against trunk revision 762602. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        this patch fixes a compiler problem seen by some users. (also use std std::string)

        Show
        Patrick Hunt added a comment - this patch fixes a compiler problem seen by some users. (also use std std::string)
        Hide
        Patrick Hunt added a comment -

        this works for me which is unusual (with almost the same gcc but on ubuntu).

        no reason not to fix it in 3.2 though

        Show
        Patrick Hunt added a comment - this works for me which is unusual (with almost the same gcc but on ubuntu). no reason not to fix it in 3.2 though

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Nitay Joffe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development