[ZOOKEEPER-3192] zoo_multi/zoo_amulti crash

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.4.13
• Component/s: c client

Environment

VS2013 Building （/MD）

• Flags: Important
• Assignee: Unassigned
• Reporter: Jian Wang
• Created: 16/Nov/18 01:16
• Updated: 11/May/23 15:22
• Resolved: 11/May/23 15:22

Description

In the zoo_amulti function (zookeeper.c) , it seems an initialization problem.

struct RequestHeader h = { STRUCT_INITIALIZER(xid, get_xid()), STRUCT_INITIALIZER(type, ZOO_MULTI_OP) };
struct MultiHeader mh = { STRUCT_INITIALIZER(type, -1), STRUCT_INITIALIZER(done, 1), STRUCT_INITIALIZER(err, -1) };
struct oarchive *oa = create_buffer_oarchive();
completion_head_t clist = { 0 };

variable "clist" 's member cond and lock are not initialized correctly. They should be initialized by pthread_cond_init and pthread_mutex_init. Otherwise zoo_amulti would crash when queue_completion was called witch calls pthread_cond_boardcast using clist->cond

Issue Links

• relates to: ZOOKEEPER-1614 zoo_multi c MT client windows crash