[ZOOKEEPER-3158] firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Component/s: server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Ling Mao
• Created: 29/Sep/18 03:47
• Updated: 19/Feb/19 10:49

Description

look at the source code in the ClientCnxnSocketNetty.connect(InetSocketAddress):

public void operationComplete(ChannelFuture channelFuture) throws Exception {
            // this lock guarantees that channel won't be assgined after cleanup().
            connectLock.lock();
                try {
                    //----------------------
                    sendThread.primeConnection();
                    //-----------------------
                    firstConnect.countDown();
                    LOG.info("channel is connected: {}", channelFuture.getChannel());
                } finally {
                    connectLock.unlock();
                }
            }
 });

firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception,it should be put into finally code block.

Issue Links

• links to: GitHub Pull Request #667
• links to: GitHub Pull Request #667