[ZOOKEEPER-3136] Reduce log in ClientBase in case of ConnectException

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Enrico Olivelli
• Reporter: Enrico Olivelli
• Created: 31/Aug/18 21:36
• Updated: 07/Sep/18 02:20
• Resolved: 07/Sep/18 00:49

Description

While running tests you will always see spammy log lines like the ones below.

As we are expecting the server to be up, it is not useful to log such stacktraces.

The patch simply reduce the log in this specific case, because it adds no value and it is very annoying.

 

     [junit] 2018-08-31 23:31:49,173 [myid:] - INFO  [main:ClientBase@292] - server 127.0.0.1:11222 not up
    [junit] java.net.ConnectException: Connection refused (Connection refused)
    [junit]     at java.net.PlainSocketImpl.socketConnect(Native Method)
    [junit]     at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
    [junit]     at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
    [junit]     at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
    [junit]     at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
    [junit]     at java.net.Socket.connect(Socket.java:589)
    [junit]     at org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:101)
    [junit]     at org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:71)
    [junit]     at org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:285)
    [junit]     at org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:276)

 

Issue Links

• links to: GitHub Pull Request #614