[ZOOKEEPER-3135] update lastSend, lastHeard with current timestamp when client reconnects successfully

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: yangkun
• Created: 30/Aug/18 02:58
• Updated: 21/Feb/20 06:49

Description

ClientCnxnSocket#updateLastSendAndHeard() method update lastSend、lastHeard to now:

 

void updateLastSendAndHeard() {
    this.lastSend = now;
    this.lastHeard = now;
}

void updateNow() {
    now = Time.currentElapsedTime();
}

In SendThread#run() method, there are some place call updateLastSendAndHeard() method, simplified as follows:

 

public void run() {
    clientCnxnSocket.updateNow();
    // place-1. update lastSend、lastHeard
    clientCnxnSocket.updateLastSendAndHeard();
    while (state.isAlive()) {
        try {
        // ...some operation
        startConnect(serverAddress);
        // place-2. update lastSend、lastHeard
        clientCnxnSocket.updateLastSendAndHeard();
    }
}

 

If so, place-1 and place-2, the lastSend、lastHeard value is equals, However, between place-1 and place-2 has some operation,consume some time,it should actually be unequal.

 

 

 

 

Issue Links

• links to: GitHub Pull Request #1065