[ZOOKEEPER-3065] Refactor existing reconfig tests in StaticHostProviderTest

• Type: Test
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.6.0
• Component/s: tests
• Assignee: Andor Molnar
• Reporter: Andor Molnar
• Created: 18/Jun/18 12:52
• Updated: 03/Feb/22 08:50

Description

The following issues would be nice to address:

• Tests cover addresses with IP addresses only, a few of them test unresolved hostnames, but ideal would be to create Test parameters and run all tests for both cases,
• Test methods should be split into multiple to cover one test case / test method,
• Style: instead of assertTrue(a < b), we should use assertThat(b, greaterThan(a))
• Extract redundant code snippets into methods