[ZOOKEEPER-3020] Review of SyncRequestProcessor

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Labels: pull-request-available
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 18/Apr/18 23:43
• Updated: 01/May/19 01:27
• Resolved: 30/Apr/19 16:08

Description

1. Use ArrayDeque instead of LinkedList
2. Use ThreadLocalRandom instead of Random
3. Remove the 'running' flag - use the Thread#join facility to detect if the thread has stopped running. Using a flag can cause race condition issues and is superfluous.
4. Make static final variable names in all caps
5. General cleanup

This class is likely to be faster than Stack when used as a stack, and faster than LinkedList when used as a queue.

https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html

Issue Links

• links to: GitHub Pull Request #869
• links to: GitHub Pull Request #876