[ZOOKEEPER-2923] The comment of the variable matchSyncs in class CommitProcessor has a mistake.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.10, 3.5.3
• Fix Version/s: 3.5.4, 3.6.0, 3.4.12
• Component/s: quorum
• Hadoop Flags: Reviewed
• Assignee: Jiafu Jiang
• Reporter: Jiafu Jiang
• Created: 23/Oct/17 02:25
• Updated: 15/Nov/17 22:32
• Resolved: 15/Nov/17 21:48

Description

The comment of the variable matchSyncs in class CommitProcessor says:

    /**
     * This flag indicates whether we need to wait for a response to come back from the
     * leader or we just let the sync operation flow through like a read. The flag will
     * be true if the CommitProcessor is in a Leader pipeline.
     */
    boolean matchSyncs;

I search the source code and find that matchSyncs will be false if the CommitProcessor is in a Leader pipeline, and it will be true if the CommitProcessor is in a Follower pipeline.
Therefore I think the comment should be modified to match the code.

Issue Links

• links to: GitHub Pull Request #408