[ZOOKEEPER-2901] Session ID that is negative causes mis-calculation of Ephemeral Type

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.5.3
• Fix Version/s: 3.5.4, 3.6.0
• Component/s: server
• Labels: ttl_nodes

Environment

Running 3.5.3-beta in Docker container

• Assignee: Jordan Zimmerman
• Reporter: Mark Johnson
• Created: 20/Sep/17 18:54
• Updated: 21/Jan/19 14:52
• Resolved: 09/May/18 22:12

Description

In the code that determines the EphemeralType it is looking at the owner (which is the client ID or connection ID):

EphemeralType.java:

public static EphemeralType get(long ephemeralOwner) {
if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER)

{ return CONTAINER; }

if (ephemeralOwner < 0)

{ return TTL; }

return (ephemeralOwner == 0) ? VOID : NORMAL;
}

However my connection ID is:

header.getClientId(): -720548323429908480

This causes the code to think this is a TTL Ephemeral node instead of a
NORMAL Ephemeral node.

This also explains why this is random - if my client ID is non-negative
then the node gets added correctly.

Issue Links

• relates to: ZOOKEEPER-2503 do a hard constraints on the number of myid which must between 0 and 255
• relates to: ZOOKEEPER-2163 Introduce new ZNode type: container
• relates to: ZOOKEEPER-2169 Enable creation of nodes with TTLs
• links to: GitHub Pull Request #377

Sub-Tasks

• Port ZOOKEEPER-2901 to 3.5.4: Resolved