Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
      None
    1. configure.ac.patch
      2 kB
      Andrew Kornev
    2. ZOOKEEPER-25_2.patch
      294 kB
      Mahadev konar
    3. ZOOKEEPER-25.patch.gz
      62 kB
      Patrick Hunt

      Activity

      Patrick Hunt created issue -
      Hide
      Patrick Hunt added a comment -

      Submitting ZooKeeper FUSE support.

      Show
      Patrick Hunt added a comment - Submitting ZooKeeper FUSE support.
      Patrick Hunt made changes -
      Field Original Value New Value
      Attachment ZOOKEEPER-25.patch.gz [ 12385133 ]
      Hide
      Patrick Hunt added a comment -

      Please review and provide feedback. I've tested this on an Ubuntu Linux system. See the README.txt for details on how to build.

      Show
      Patrick Hunt added a comment - Please review and provide feedback. I've tested this on an Ubuntu Linux system. See the README.txt for details on how to build.
      Hide
      Mahadev konar added a comment -

      this patch contains files like configure and others which are autogenerated by autoconf. we should get rid of them and change out README to say run autoconf — and then do ......

      Show
      Mahadev konar added a comment - this patch contains files like configure and others which are autogenerated by autoconf. we should get rid of them and change out README to say run autoconf — and then do ......
      Hide
      Patrick Hunt added a comment -

      Updated the patch to remove some autoconf generated files that don't need to be committed to SVN.

      Show
      Patrick Hunt added a comment - Updated the patch to remove some autoconf generated files that don't need to be committed to SVN.
      Patrick Hunt made changes -
      Attachment ZOOKEEPER-25.patch.gz [ 12385144 ]
      Patrick Hunt made changes -
      Attachment ZOOKEEPER-25.patch.gz [ 12385133 ]
      Hide
      Andrew Kornev added a comment -

      This patch replaces the existing FUSE configure.ac: the configure.ac script uses some macros that are not supported by the pre-2.61 autoconf tools. It's safe to drop the macros from the script for the sake of compatibility with autotools 2.59. The C client is also compatible with version 2.59.

      Other than that I was able to build and run FUSE with zookeeper without any problems.

      +1

      Show
      Andrew Kornev added a comment - This patch replaces the existing FUSE configure.ac: the configure.ac script uses some macros that are not supported by the pre-2.61 autoconf tools. It's safe to drop the macros from the script for the sake of compatibility with autotools 2.59. The C client is also compatible with version 2.59. Other than that I was able to build and run FUSE with zookeeper without any problems. +1
      Andrew Kornev made changes -
      Attachment configure.ac.patch [ 12386096 ]
      Andrew Kornev made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      Mahadev konar added a comment -

      the patch looks good. Some comments –

      1) src/contrib/zkfuse/AUTHORS.txt
      can we remove this file? Usually in apache authors tags are avoided since they are chanaged over and over by others and mentioning that the code belongs to someone becomes wrong to say.

      2) src/contrib/zkfuse/ChangeLog

      can we remove this file as well? The changelog does not match any svn revisions on apache – or any revisions that are open source...

      Show
      Mahadev konar added a comment - the patch looks good. Some comments – 1) src/contrib/zkfuse/AUTHORS.txt can we remove this file? Usually in apache authors tags are avoided since they are chanaged over and over by others and mentioning that the code belongs to someone becomes wrong to say. 2) src/contrib/zkfuse/ChangeLog can we remove this file as well? The changelog does not match any svn revisions on apache – or any revisions that are open source...
      Hide
      Mahadev konar added a comment -

      this patch has changes with authors.txt removed and changelog cleaned up./

      Show
      Mahadev konar added a comment - this patch has changes with authors.txt removed and changelog cleaned up./
      Mahadev konar made changes -
      Attachment ZOOKEEPER-25_2.patch [ 12388168 ]
      Hide
      Mahadev konar added a comment -

      I just committed this. Thanks Swee, Bart, Pat and Andrew.

      Show
      Mahadev konar added a comment - I just committed this. Thanks Swee, Bart, Pat and Andrew.
      Mahadev konar made changes -
      Fix Version/s 3.0.0 [ 12313216 ]
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Hide
      Hudson added a comment -

      Integrated in ZooKeeper-trunk #53 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/)

      Show
      Hudson added a comment - Integrated in ZooKeeper-trunk #53 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/53/ )
      Hide
      Patrick Hunt added a comment -

      3.0.0 has been released, closing issues.

      Show
      Patrick Hunt added a comment - 3.0.0 has been released, closing issues.
      Patrick Hunt made changes -
      Status Resolved [ 5 ] Closed [ 6 ]

        People

        • Assignee:
          Patrick Hunt
          Reporter:
          Patrick Hunt
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development