[ZOOKEEPER-2361] Revisit 'VisibleForTesting' phrase used to indicate a member or method visible for testing

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Rakesh Radhakrishnan
• Reporter: Rakesh Radhakrishnan
• Created: 04/Feb/16 18:02
• Updated: 04/Feb/16 19:23

Description

ZooKeeper uses // VisibleForTesting comment to indicate a member or method which is visible for unit testing. The idea of this jira is to discuss better ways to convey the message more clear and implement the same. One idea could use annotations, needs to introduce @VisibleForTesting

For example,
ContainerManager.java#L134, PurgeTxnLog.java#L78, ZooKeeper.java#L1011 etc.

ZooKeeper.java
    // VisibleForTesting
    public Testable getTestable() {
        return new ZooKeeperTestable(this, cnxn);
    }

PurgeTxnLog.java
    // VisibleForTesting
    static void retainNRecentSnapshots(FileTxnSnapLog txnLog, List<File> snaps) {