[ZOOKEEPER-2284] LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.6.0, 3.5.5
• Labels: pull-request-available
• Assignee: Ling Mao
• Reporter: Mohammad Arshad
• Created: 28/Sep/15 18:27
• Updated: 20/May/19 17:51
• Resolved: 22/Feb/19 09:45

Description

LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully. If file no exist then these classes propagate the exception to console.

Exception in thread "main" java.io.FileNotFoundException: log.1 (The system cannot find the file specified)
        at java.io.FileInputStream.open(Native Method)
        at java.io.FileInputStream.<init>(FileInputStream.java:146)
        at java.io.FileInputStream.<init>(FileInputStream.java:101)
        at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)

File existence should be validated and appropriate message should be displayed on console if file does not exist

Issue Links

• links to: GitHub Pull Request #630
• links to: GitHub Pull Request #630