[ZOOKEEPER-2264] Wrong error message when secureClientPortAddress is configured but secureClientPort is not configured

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.5.2, 3.6.0
• Component/s: server
• Assignee: Mohammad Arshad
• Reporter: Mohammad Arshad
• Created: 31/Aug/15 13:22
• Updated: 21/Jul/16 20:18
• Resolved: 06/Sep/15 18:06

Description

1. Wrong error message when secureClientPortAddress is configured but secureClientPort is not configured.
   zookeeper throws IllegalArgumentException with error message clientPortAddress is set but clientPort is not set but should be secureClientPortAddress is set but secureClientPort is not set
2. There is another problem with the same code.
   value is assigned to local variable but null check is done on instance variable so we will never get error message for this scenario.

   if (this.secureClientPortAddress != null) {

   should be replaced with

   if (secureClientPortAddress != null) {

3. Above problem is there for clientPort scenario also. So we should replace

   if (this.clientPortAddress != null) {

   with

   if (clientPortAddress != null) {